Review 9.5 Merged

61514[BUGFIX] Ensure manually updated slug is saved correctly

Andreas Kienast CR +2 V +2 Easy +12 −6 updated 08/20/19, 09:05

Commit message

This fixes the bug, that after updating the slug and clicking
the toggle URL button, the slug isn't updated correctly.

Therefore, if the value of the input and read only field differ
after clicking the toggle button, now the updated value
of the input field is written into the read only and hidden field.

Furthermore after recreating the slug, the new value is now also
written into the input field to be present after clicking
the toogle URL button again. Otherwise the recreated slug would be
discarded on save.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 34

  1. Andreas Kienast uploaded patch set 1 08/20/19, 08:52

  2. TYPO3com voted on patch set 1 V +1 08/20/19, 09:04 Completed build in 12m 36s on Tue, 20 Aug, 09:04 AM Test Summary: 50568 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1032

  3. Andreas Kienast voted on patch set 1 V +2 CR +2 08/20/19, 09:05

  4. Andreas Kienast merged patch set 2 08/20/19, 09:05