61519[BUGFIX] Set module state only if UC structure is intact
Commit message
Review
-
Code review CR +2 Done
- Anja Leichsenring +2
- Oliver Klee +1
- Frank Nägler +1
- Moritz Ngo +1
-
Verified V +2 Done
- Anja Leichsenring +2
- Moritz Ngo +1
- Tobias Wollender +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 2429
Show 34 earlier messages
-
Andreas Kienast uploaded patch set 1 08/20/19, 12:53
-
Richard Haeser voted on patch set 1 CR +1 08/20/19, 13:01
-
TYPO3com voted on patch set 1 V +1 08/20/19, 13:04 Completed build in 11m 31s on Tue, 20 Aug, 01:04 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35747
-
Andreas Kienast commented on patch set 1 CR -1 08/20/19, 13:16
still broken
-
Andreas Kienast uploaded patch set 2 08/20/19, 13:19
-
TYPO3com voted on patch set 2 V -1 08/20/19, 13:30 Completed build in 10m 46s on Tue, 20 Aug, 01:30 PM Test Summary: 1 of 47570 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35749
-
TYPO3com voted on patch set 2 V +1 08/20/19, 13:37 Completed build in 28m 16s on Tue, 20 Aug, 01:37 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35749
-
Oliver Klee voted on patch set 2 CR +1 08/20/19, 19:24
-
Markus Klein updated the commit message in patch set 3 08/20/19, 20:03
-
TYPO3com voted on patch set 3 V +1 08/20/19, 20:13 Completed build in 10m 24s on Tue, 20 Aug, 08:13 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35751
-
Oliver Klee voted on patch set 3 CR +1 08/20/19, 21:36
-
Rémy DANIEL commented on patch set 3 CR -1 08/22/19, 07:27
IMHO the fix, which finally prevents wrong uc type, should not be in the BackendController, but should be somewhere in \TYPO3\CMS\Core\Authentication\BackendUserAuthentication::backendSetUC() or \TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::unpack_uc() -
Andreas Kienast commented on patch set 3 08/22/19, 07:39
> Patch Set 3: Code-Review-1 > > IMHO the fix, which finally prevents wrong uc type, should not be in the BackendController, but should be somewhere in \TYPO3\CMS\Core\Authentication\BackendUserAuthentication::backendSetUC() or \TYPO3\CMS\Core\Authentication\AbstractUserAuthentication::unpack_uc() I object here: this would be actually a heavy breaking change since some data relies to be stored as an object! -
Rémy DANIEL commented on patch set 3 08/22/19, 09:05
In a uc of a TYPO3 6.2 instance, I found other cases in uc['BackendComponents']['States'] where states are StdClass and not an array: typo3-debug-console, Pagetree, typo3-navigationContainer, typo3-module-menu In the Pagetree controller, there is another way to "test" for the malformation of uc: see \TYPO3\CMS\Backend\Controller\Page\TreeController in line 184 : $this->expandedState = $backendUserConfiguration->get('BackendComponents.States.Pagetree'); if (is_object($this->expandedState) && is_object($this->expandedState->stateHash)) { $this->expandedState = (array)$this->expandedState->stateHash; } else { $this->expandedState = $this->expandedState['stateHash'] ?: []; } We see that 'BackendComponents.States.Pagetree' is not expected as an object. My point is: does each Controller or JS getting/storing values in uc will test for a potential wrong type of the values? Or is it preferable and possible to "fix" it at a higher level? -
Andreas Kienast commented on patch set 3 08/22/19, 09:34
> My point is: does each Controller or JS getting/storing values in uc will test for a potential wrong type of the values? Or is it preferable and possible to "fix" it at a higher level? There are plans to streamline (=refactor) the whole UC thing, but that needs proper concepts. -
Pascal Querner commented on patch set 3 08/22/19, 14:07
BackendController.php:210$collapseState === 'true' can no longer happen since Method getCollapseStateOfMenu returns boolean already. -
Pascal Querner wrote 08/22/19, 14:11
Removed reviewer Pascal Querner. -
Andreas Kienast commented on patch set 3 08/22/19, 14:12
BackendController.php:210Reply UnresolvedThat's true, will fix accordingly -
Tobias Wollender voted on patch set 3 V +1 08/22/19, 14:12
-
Andreas Kienast commented on patch set 4 08/22/19, 14:12
Published edit on patch set 3. -
Moritz Ngo voted on patch set 4 V +1 CR +1 08/22/19, 14:15
-
Tobias Wollender voted on patch set 4 V +1 08/22/19, 14:17
-
Oliver Klee voted on patch set 4 CR +1 08/22/19, 14:30
-
TYPO3com voted on patch set 4 V +1 08/22/19, 14:42 Completed build in 26m 10s on Thu, 22 Aug, 02:42 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35771
-
Frank Nägler voted on patch set 4 CR +1 08/23/19, 09:29
-
Frank Nägler commented on patch set 4 CR -1 08/23/19, 09:31
on it -
Frank Nägler voted on patch set 4 CR +1 08/23/19, 09:37
-
Anja Leichsenring voted on patch set 4 V +2 CR +2 08/23/19, 09:46
-
Anja Leichsenring merged patch set 5 08/23/19, 09:46