61521[WIP][TASK] Unify handling of errorParams in linkvalidator
Commit message
Review
-
Code review CR 0
-
Verified V 0
Issues 1
Files 8
- typo3/sysext/linkvalidator/Classes/Linktype/AbstractLinktype.php19+37 −10
- typo3/sysext/linkvalidator/Classes/Linktype/ExternalLinktype.php4+23 −31
- typo3/sysext/linkvalidator/Classes/Linktype/FileLinktype.php13+17 −9
- typo3/sysext/linkvalidator/Classes/Linktype/InternalLinktype.php4+7 −12
- typo3/sysext/linkvalidator/Classes/Linktype/LinkHandler.php4+34 −22
- typo3/sysext/linkvalidator/Classes/Linktype/LinktypeInterface.php3+3 −3
- typo3/sysext/linkvalidator/Classes/Report/LinkValidatorReport.php+1 −1
- typo3/sysext/linkvalidator/Tests/Unit/Linktype/ExternalLinktypeTest.php+1 −1
Review log 1420
-
Sybille Peters uploaded patch set 1 08/21/19, 12:40
-
TYPO3com voted on patch set 1 V +1 08/21/19, 12:51 Completed build in 11m 01s on Wed, 21 Aug, 12:51 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35757
-
Oliver Klee commented on patch set 1 08/22/19, 11:02
AbstractLinktype.php:48Should the field really be unset, or should it be emptied instead (i.e., set to an empty array so that it always is an array)?AbstractLinktype.php:54As you touch the method, you can use the opportunity to also add the :void return typew.AbstractLinktype.php:69I don't think we need the PHPDoc as long as it does not add anything to what the type declarations already say. Ditto for the other methods.AbstractLinktype.php:78: voidAbstractLinktype.php:94: voidAbstractLinktype.php:110: voidExternalLinktype.php:97: voidFileLinktype.php:27@var stringFileLinktype.php:62As of PHP 7.1, you can combine these two catch clauses into one: https://stackoverflow.com/questions/8439581/catching-multiple-exception-types-in-one-catch-blockFileLinktype.php:69As $idValidUrl is a boolean anyway, you can shorten ($isValidUrl === true) to ($isValidUrl) and ($isValidUrl === false) to (!$isValidUrl).FileLinktype.php:82As you touch the signature anyway, you can add a :string return type declaration.InternalLinktype.php:226: stringLinkHandler.php:134: stringLinktypeInterface.php:62: string -
Sybille Peters uploaded patch set 2 08/22/19, 15:54
-
Sybille Peters commented on patch set 2 08/22/19, 16:00
AbstractLinktype.php:46ReplyDoneAbstractLinktype.php:48ReplyDoneAbstractLinktype.php:54ReplyDoneAbstractLinktype.php:69ReplyDoneAbstractLinktype.php:78ReplyDoneAbstractLinktype.php:94ReplyDoneAbstractLinktype.php:110ReplyDoneExternalLinktype.php:97ReplyDoneFileLinktype.php:27ReplyDoneFileLinktype.php:62ReplyDoneFileLinktype.php:69ReplyDoneFileLinktype.php:82ReplyDoneInternalLinktype.php:226ReplyDoneLinkHandler.php:134ReplyDoneLinktypeInterface.php:62ReplyDone -
TYPO3com voted on patch set 2 V +1 08/22/19, 16:04 Completed build in 09m 46s on Thu, 22 Aug, 04:04 PM Test Summary: 47211 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35773
-
Oliver Klee commented on patch set 2 08/25/19, 16:46
AbstractLinktype.php:52If I understand this correctly, $value is expected to be an array of strings. So we can change the PHPDoc type annotation (not the type declaration) to string[] to make this explicit.AbstractLinktype.php:66Do we need string casts in all the new getters (as it's possible to pass an array of non-string values as well)?ExternalLinktype.php:144Shorter: if ($isValidUrl)FileLinktype.php:27For consistency, I propose changing this to the three-line DocBlock.FileLinktype.php:67Shorter: $isValidURL = $isValidURL && $file !== null && !$file->isMissing(); -
Sybille Peters uploaded patch set 3 09/17/19, 16:41
-
Sybille Peters commented on patch set 2 09/17/19, 16:41
AbstractLinktype.php:52ReplyDoneAbstractLinktype.php:66Reply UnresolvedI don't understand this comment.ExternalLinktype.php:144ReplyDoneFileLinktype.php:27ReplyDoneFileLinktype.php:67ReplyDone -
TYPO3com voted on patch set 3 V +1 09/17/19, 16:51 Completed build in 10m 04s on Tue, 17 Sep, 04:51 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36525
-
Lina Wolf commented on patch set 3 V -1 09/17/19, 20:14
I created test links of the following kinds: tt_content:bodytext internal link to a hidden page error message before: "Page 'hidden page' (3) is not visible." Afterwards: "No information about the error is available." The error message for a missing file stays the same. Error for an external url pointing to a 404 page Before: "The requested url was not found (404)" afterwards: "No information about the error is available." I think the error messages before contained much more information. I did truncate the table tx_linkvalidator_link to force regeneration of error codes. Still the "No information" error messages stay. -
Sybille Peters uploaded patch set 4 09/18/19, 07:00
-
TYPO3com voted on patch set 4 V +1 09/18/19, 07:10 Completed build in 10m 06s on Wed, 18 Sep, 07:10 AM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36527
-
Sybille Peters uploaded patch set 5 09/18/19, 15:34
-
TYPO3com voted on patch set 5 V +1 09/18/19, 15:49 Completed build in 11m 51s on Wed, 18 Sep, 03:49 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36558
-
Sybille Peters uploaded patch set 6 09/18/19, 16:11
-
TYPO3com voted on patch set 6 V +1 09/18/19, 16:21 Completed build in 09m 24s on Wed, 18 Sep, 04:21 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36559
-
Tymoteusz Motylewski commented on patch set 6 CR -1 10/23/19, 08:25
AbstractLinktype.php:65Unresolvedwhy does it take 3 types? haven't you simplified it?FileLinktype.php:79Unresolvedplease do not change public functions interfaceInternalLinktype.php:33Unresolvedchnge in conts, no breaking changes pleaseInternalLinktype.php:222Unresolvedsame hereLinkHandler.php:34Unresolvedsame hereLinkHandler.php:134Unresolvedsame here, we can't change interface of the public methods (breaking change)LinktypeInterface.php:63Unresolvedand here -
Benni Mack commented on patch set 6 02/15/20, 09:25
What is the status of this change? Will somebody pick this up? -
Sybille Peters abandoned the change 02/16/20, 08:01
Abandoning for now. Too many changes in the meantime.
AbstractLinktype.php:46