Review main Merged

61523[BUGFIX] Remove canonicalized pages from XML sitemap

Richard Haeser CR +2 V +2 Easy +23 −3 updated 08/27/19, 21:26

Commit message

Pages with a canonical link set in the page properties, will not
be shown in the XML sitemap anymore.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Guido Schmechel +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 1217

  1. Richard Haeser uploaded patch set 1 08/22/19, 12:10

  2. Richard Haeser updated the commit message in patch set 2 08/22/19, 12:17

  3. TYPO3com voted on patch set 1 V +1 08/22/19, 12:22 Completed build in 12m 35s on Thu, 22 Aug, 12:22 PM Test Summary: 47214 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35763

  4. TYPO3com voted on patch set 2 V +1 08/22/19, 12:34 Completed build in 15m 20s on Thu, 22 Aug, 12:34 PM Test Summary: 47214 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35765

  5. Guido Schmechel commented on patch set 2 08/22/19, 13:11

    Two questions 1.) Should we adapt the existing rst files? Example: typo3/sysext/core/Documentation/Changelog/9.4/Feature-84525-XMLSitemap.rst 2.) Example hints me to "no_follow" Should we adapt the typoscript or the doc?
  6. Richard Haeser commented on patch set 2 CR -1 08/22/19, 13:14

    > Patch Set 2: > > Two questions > 1.) Should we adapt the existing rst files? Example: typo3/sysext/core/Documentation/Changelog/9.4/Feature-84525-XMLSitemap.rst > 2.) Example hints me to "no_follow" Should we adapt the typoscript or the doc? I think we should alter that file indeed: add the canonical_link = '' and remove the no_follow part. If a search engine is advised to not check any links, thats fine, but is not telling Google to not index the current page. So having no_follow in the example is not the best example.
  7. Richard Haeser uploaded patch set 3 08/22/19, 13:17

  8. TYPO3com voted on patch set 3 V +1 08/22/19, 13:27 Completed build in 09m 54s on Thu, 22 Aug, 01:27 PM Test Summary: 47214 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35768

  9. Guido Schmechel voted on patch set 3 CR +1 08/22/19, 13:33

  10. Oliver Klee commented on patch set 3 08/22/19, 14:40

    XmlSitemapPagesTest.php:91 Unresolved

    Usually, test names should not be named like "check if" or "test if", but contain a sentence with a statement instead (e.g., "addForTwoPositiveNumbersReturnsSum"). In this case, I propose this name: pagesSitemapNotContainsUrlWithCanonicalSet
  11. Anja Leichsenring commented on patch set 4 08/23/19, 10:52

    Published edit on patch set 3.
  12. Anja Leichsenring voted on patch set 4 V +1 CR +1 08/23/19, 10:52

  13. TYPO3com voted on patch set 4 V -1 08/23/19, 11:03 Completed build in 10m 56s on Fri, 23 Aug, 11:03 AM Test Summary: 1 of 47577 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35797

  14. TYPO3com voted on patch set 4 V +1 08/23/19, 12:05 Completed build in 1h 23m 52s on Fri, 23 Aug, 12:05 PM Test Summary: 47218 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35797

  15. Guido Schmechel voted on patch set 4 V +1 CR +1 08/27/19, 21:01

  16. Richard Haeser voted on patch set 4 V +2 CR +2 08/27/19, 21:26

  17. Richard Haeser merged patch set 5 08/27/19, 21:26