Review main Merged

61531[BUGFIX] Fix frontend error handling when root page is protected

Helmut Hummel CR +2 V +2 Easy +10 −5 updated 08/30/19, 11:20

Commit message

If the root page is accessed directly, we add a check whether
the page could be fetched with ignored group permissions.
If that is the case, an access denied is triggered.

If the root page also has the extendToSubPages flag set,
we must not remove the page from the root line, which would
trigger a service unavailable handling, but instead
keep the root line and trigger a page not found.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Markus Klein +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 810

  1. Helmut Hummel uploaded patch set 1 08/23/19, 11:23

  2. TYPO3com voted on patch set 1 V +1 08/23/19, 11:32 Completed build in 08m 48s on Fri, 23 Aug, 11:32 AM Test Summary: 47225 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35799

  3. Helmut Hummel uploaded patch set 2 08/23/19, 11:37

  4. TYPO3com voted on patch set 2 V +1 08/23/19, 11:46 Completed build in 09m 07s on Fri, 23 Aug, 11:46 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35800

  5. Markus Klein voted on patch set 2 CR +1 08/23/19, 11:56

  6. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/24/19, 15:10

  7. Richard Haeser commented on patch set 2 08/29/19, 21:07

    I can't reproduce the scenario 1 issue. I get a page not found exception on the root page. I can reproduce when "Extend to Subpages" set. All subpages get the service unavailable, but the rootpage is just giving a page not found exception. Any specific configuration needed?
  8. Andreas Kienast voted on patch set 2 V +1 CR +1 08/30/19, 11:20

  9. Anja Leichsenring voted on patch set 2 V +2 CR +2 08/30/19, 11:20

  10. Anja Leichsenring merged patch set 3 08/30/19, 11:20