61543[TASK] Add tests for linkvalidator
Commit message
Review
-
Code review CR +2 Done
- Tymoteusz Motylewski +2
-
Verified V +2 Done
- Tymoteusz Motylewski +2
- TYPO3com +1 CI
Issues 1
Files 1
Review log 69
-
Tymoteusz Motylewski commented on patch set 1 08/27/19, 21:31
Cherry Picked from branch master. -
TYPO3com voted on patch set 1 V -1 08/27/19, 21:49 Completed build in 16m 14s on Tue, 27 Aug, 09:49 PM Test Summary: 8 of 51044 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1057
-
Sybille Peters commented on patch set 1 08/28/19, 05:06
It is actually good that this test fails. It fails because of the tilde (~) used in the URL. I tested with a different URL in the unit test and that would succeed. preprocessUrl() (which gets called by checkLink() in linkvalidator) fails for this type of URL with tilde in 9.5 branch. In retrospect it might have been getter to use a more generic URL in the unit test for checkLink() and add a unit test specifically for preprocessUrl() using a tilde. Since I had been planning to add more tests anyway, I could include that change in my patch. This patch could get merged once https://review.typo3.org/c/Packages/TYPO3.CMS/+/61495 is merged. That is a specific patch for 9.5 because the functionality used in preprocessUrl() is different between master and 9.5 and in 9.5 it breaks for URLs with tilde (in the path). -
Sybille Peters voted on patch set 1 CR +1 08/28/19, 16:08
-
Tymoteusz Motylewski rebased onto patch set 2 08/29/19, 15:21
-
TYPO3com voted on patch set 2 V -1 08/29/19, 15:33 Completed build in 11m 26s on Thu, 29 Aug, 03:33 PM Test Summary: 50571 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1075
-
TYPO3com voted on patch set 2 V +1 08/29/19, 15:36 Completed build in 26m 15s on Thu, 29 Aug, 03:36 PM Test Summary: 50581 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1075
-
Tymoteusz Motylewski voted on patch set 2 V +2 CR +2 08/29/19, 15:48
-
Tymoteusz Motylewski merged patch set 3 08/29/19, 15:48