Review main Abandoned

61552[TASK] Use context in database restrictions

Manuel Selbach CR 0 V 0 Normal +218 −25 updated 11/04/21, 14:43

Commit message

With this change it is possible to pass a context to

TYPO3\CMS\Core\Database\ConnectionPool::getQueryBuilderForTable

TYPO3\CMS\Core\Database\Connection::createQueryBuilder

as optional parameter.

Is the QueryBuilder retrieved with a context all queries get the
restrictions applied that are defined for that context automatically.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 12

Review log 812

  1. Manuel Selbach uploaded patch set 1 08/23/19, 16:07

  2. TYPO3com voted on patch set 1 V -1 08/23/19, 16:07 Completed build in 14s on Fri, 23 Aug, 04:07 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35807

  3. Manuel Selbach uploaded patch set 2 08/23/19, 16:25

  4. TYPO3com voted on patch set 2 V -1 08/23/19, 16:25 Completed build in 15s on Fri, 23 Aug, 04:25 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35808

  5. Manuel Selbach uploaded patch set 3 08/26/19, 07:57

  6. Manuel Selbach wrote 08/26/19, 07:59

    Topic set to persistence
  7. TYPO3com voted on patch set 3 V +1 08/26/19, 08:08 Completed build in 11m 26s on Mon, 26 Aug, 08:08 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35838

  8. Manuel Selbach marked it work in progress 10/23/19, 14:07

  9. Manuel Selbach uploaded patch set 4 10/23/19, 14:13

  10. TYPO3com voted on patch set 4 V -1 10/23/19, 14:25 Completed build in 11m 22s on Wed, 23 Oct, 02:25 PM Test Summary: 1 of 48121 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37518

  11. Oliver Hader commented on patch set 4 10/24/19, 13:50

    ContextRestrictionResolver.php:32 Unresolved

    How to handle duplicate restrictions here (e.g. AspectA has DeletedRestriction and AspectB has DeletedRestriction as well)
  12. Benni Mack abandoned the change 11/04/21, 14:43

    not used anymore