Review main Abandoned

61553[TASK] Add missing dependencies to composer.json of extbase

Alexander Schnitzler CR 0 V 0 Easy +23 −2 updated 03/18/20, 13:47

Commit message

To allow static code analysis and to prevent broken code if dependencies
are not installed.

Review

  • Code review CR 0
  • Verified V 0

Issues 1

Files 1

Review log 1117

  1. Alexander Schnitzler uploaded patch set 1 08/24/19, 12:16

  2. TYPO3com voted on patch set 1 V +1 08/24/19, 12:26 Completed build in 10m 19s on Sat, 24 Aug, 12:26 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35815

  3. Daniel Siepmann uploaded patch set 2 10/26/19, 07:37

  4. Daniel Siepmann updated the commit message in patch set 3 10/26/19, 07:38

  5. TYPO3com voted on patch set 2 V -1 10/26/19, 08:01 Completed build in 19m 41s on Sat, 26 Oct, 08:01 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37761

  6. TYPO3com voted on patch set 3 V -1 10/26/19, 08:02 Completed build in 20m 45s on Sat, 26 Oct, 08:02 AM Test Summary: 2 of 48418 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37762

  7. Oliver Klee voted on patch set 3 CR +1 10/26/19, 08:26

  8. TYPO3com commented on patch set 3 10/26/19, 08:46 Completed build in 1h 24m 46s on Sat, 26 Oct, 08:46 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37762

  9. TYPO3com commented on patch set 3 10/26/19, 08:46 Completed build in 11m 33s on Sat, 26 Oct, 08:46 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37766

  10. Daniel Siepmann uploaded patch set 4 10/26/19, 08:54

  11. TYPO3com voted on patch set 4 V +1 10/26/19, 09:06 Completed build in 10m 59s on Sat, 26 Oct, 09:05 AM Test Summary: 48059 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37769

  12. Oli Bartsch voted on patch set 4 CR +1 10/26/19, 09:15

  13. Alexander Schnitzler commented on patch set 4 10/26/19, 13:59

    This change is ready for review.
  14. Oliver Klee voted on patch set 4 CR +1 10/26/19, 17:11

  15. Daniel Siepmann voted on patch set 4 CR +1 10/28/19, 15:19

  16. Alexander Schnitzler commented on patch set 4 CR -1 10/29/19, 12:50

    We are discussing this atm in the core team because it has affects on the sub tree split stuff.
  17. Georg Ringer abandoned the change 03/18/20, 13:47