Review main Merged

61554[FEATURE] Introduce site config import for distributions

Anja Leichsenring CR +2 V +2 Normal +203 −5 updated 09/02/19, 04:26

Commit message

Distributions or site packages can now ship their preconfigured
site configurations in Initialisation/Site and see it moved into
place upon extension activation.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 2332

Show 47 earlier messages
  1. Anja Leichsenring uploaded patch set 1 08/25/19, 09:16

  2. Anja Leichsenring uploaded patch set 2 08/25/19, 09:24

  3. TYPO3com voted on patch set 2 V -1 08/25/19, 09:25 Completed build in 12s on Sun, 25 Aug, 09:25 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35827

  4. TYPO3com voted on patch set 1 V -1 08/25/19, 09:26 Completed build in 09m 36s on Sun, 25 Aug, 09:26 AM Test Summary: 24 of 47586 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35826

  5. Anja Leichsenring uploaded patch set 3 08/25/19, 09:26

  6. TYPO3com commented on patch set 3 08/25/19, 09:27 Completed build in 11s on Sun, 25 Aug, 09:27 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35828

  7. Anja Leichsenring uploaded patch set 4 08/25/19, 09:29

  1. Anja Leichsenring uploaded patch set 5 08/25/19, 09:30

  2. TYPO3com voted on patch set 4 V -1 08/25/19, 09:30 Completed build in 16s on Sun, 25 Aug, 09:30 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35829

  3. TYPO3com voted on patch set 5 V +1 08/25/19, 09:41 Completed build in 10m 43s on Sun, 25 Aug, 09:41 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35830

  4. Anja Leichsenring uploaded patch set 6 08/25/19, 11:00

  5. Anja Leichsenring uploaded patch set 7 08/25/19, 11:05

  6. TYPO3com voted on patch set 6 V +1 08/25/19, 11:11 Completed build in 10m 54s on Sun, 25 Aug, 11:11 AM Test Summary: 47235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35832

  7. TYPO3com voted on patch set 7 V +1 08/25/19, 11:16 Completed build in 10m 46s on Sun, 25 Aug, 11:15 AM Test Summary: 47235 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35833

  8. Simon Gilli voted on patch set 7 CR +1 08/25/19, 11:50

  9. Andreas Kienast voted on patch set 7 CR +1 08/26/19, 08:12

  10. Guido Schmechel commented on patch set 7 08/26/19, 08:40

    InstallUtility.php:619

    Initialization? Or do we prefer the variant with "s"?

    InstallUtility.php:633

    Just a question: mkdir for a file? (Hint: Just only read this code)
  11. Anja Leichsenring commented on patch set 7 08/26/19, 12:34

    InstallUtility.php:619 Reply

    not my invention, it is already there. See former methods in this class.

    InstallUtility.php:633 Reply

    this is no file, but always a folder.
  12. Guido Schmechel commented on patch set 7 08/26/19, 12:41

    InstallUtility.php:619 Reply

    Done

    InstallUtility.php:633 Reply

    OK. I was only irritated by the method $siteConfigDirectory->getFilename()
  13. Richard Haeser commented on patch set 7 08/29/19, 21:18

    InstallUtility.php:633 Reply

    Can't we use the getPath() method for this? It indeed is a little bit confusing. The getFilename returns only the directory because we only search for directories.
  14. Andreas Kienast commented on patch set 7 CR -1 08/30/19, 10:29

    on it
  15. Anja Leichsenring commented on patch set 7 08/30/19, 10:31

    InstallUtility.php:633 Reply Unresolved

    we need the name of the folder to be created and then copied to. Sorry guys, I tried with more intuitively named methods of the finder component, but this what it is. The name of the folder. In Linux' lexicon everything is a file, a folder is a special kind of file.
  16. Andreas Kienast uploaded patch set 8 08/30/19, 10:34

  17. TYPO3com voted on patch set 8 V -1 08/30/19, 10:35 Completed build in 12s on Fri, 30 Aug, 10:35 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35952

  18. Andreas Kienast voted on patch set 8 V +1 CR +1 08/30/19, 10:35

  19. Andreas Kienast uploaded patch set 9 08/30/19, 10:35

  20. Andreas Kienast voted on patch set 9 V +1 CR +1 08/30/19, 10:36

  21. TYPO3com voted on patch set 9 V +1 08/30/19, 10:47 Completed build in 11m 15s on Fri, 30 Aug, 10:47 AM Test Summary: 47248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35953

  22. Richard Haeser voted on patch set 9 V +2 CR +2 08/30/19, 10:56

  23. Richard Haeser merged patch set 10 08/30/19, 10:56

  24. Benni Mack commented on patch set 10 09/02/19, 04:23

    InstallUtility.php:652 Unresolved

    Any reason why we added a new Signal instead of a new Event/PSR-14? If we add new events, we don't have do migrate and deprecate this Signal during v10 anymore.
  25. Benni Mack commented on patch set 10 09/02/19, 04:26

    InstallUtility.php:637 Unresolved

    destinationFolder is Environment::getConfigPath(). With the signal it's not clear what the site nor the site identifier name is, right?