Review main Merged

61556[BUGFIX] Remove superfluous comma in ActionController

Alexander Schnitzler CR +2 V +2 Easy +1 −1 updated 08/26/19, 10:50

Commit message

https://review.typo3.org/c/Packages/TYPO3.CMS/+/61235
introduced a superfluous trailing comma, which leads to an
InvalidArgument exception, thrown by the phpDocumentor annoation parser.

The InvalidArgument exception is actually already handled in
PhpDocPropertyTypeExtractor::getDocBlockFromProperty, but other code
that uses phpdocumentator directly would be affected.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Alexander Schnitzler uploaded patch set 1 08/26/19, 08:03

  2. Anja Leichsenring commented on patch set 1 08/26/19, 08:04

    it is a semicolon :) You can also remove the WIP, please. Else no merge is possible.
  3. Benjamin Franzke voted on patch set 1 CR +1 08/26/19, 08:04

  4. TYPO3com voted on patch set 1 V +1 08/26/19, 08:16 Completed build in 12m 19s on Mon, 26 Aug, 08:16 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35840

  5. Georg Ringer voted on patch set 1 V +1 CR +1 08/26/19, 08:31

  6. Benjamin Franzke updated the commit message in patch set 2 08/26/19, 08:56

  7. TYPO3com voted on patch set 2 V +1 08/26/19, 09:07 Completed build in 11m 06s on Mon, 26 Aug, 09:07 AM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35841

  8. Alexander Schnitzler commented on patch set 2 08/26/19, 09:08

    This change is ready for review.
  9. Oliver Klee voted on patch set 2 CR +1 08/26/19, 09:50

  10. Guido Schmechel voted on patch set 2 V +1 08/26/19, 10:38

  11. Benjamin Franzke voted on patch set 2 V +2 CR +2 08/26/19, 10:49

  12. Benjamin Franzke merged patch set 3 08/26/19, 10:50