Review main Merged

61558[FEATURE] Provide implementation for PSR-17 HTTP Message Factories

Benjamin Franzke CR +2 V +2 Expert +1023 −22 updated 09/20/19, 08:48

Commit message

Support for PSR-17 HTTP Message Factories has been added.

PSR-17 HTTP Factories are intended to be used by PSR-15 request handlers
in order to create PSR-7 compatible message objects.

Classes may use dependency injection to use any of the available PSR-17
HTTP Factory interfaces.

The Request/Response base class (Message) is adapted to be able to lazily
initialize a stream when getBody() is called.
This is done as the PSR (Stream)RequestFactoryInterface does not allow
to control Stream properties. Therefore it is a performance
optimization to defer initialization. It is likely, that a new
Stream will be added to a Request with withStream() anyway.
(Which would mean resources for the intermediate stream would have
been wasted)

Furthermore some DocBlocks are adapted to reflect the variadic
UriInterface/StreamInterface parameters that are already handled in
code but were not documented. These cases are needed/required
by the PSR-17 factory implementation now.

composer require psr/http-factory:^1.0

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benni Mack +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benni Mack +1
    • TYPO3com +1 CI

Issues 1

Files 23

Review log 2138

Show 713 earlier messages
  1. Benjamin Franzke uploaded patch set 1 08/26/19, 12:26

  2. TYPO3com voted on patch set 1 V -1 08/26/19, 12:26 Completed build in 16s on Mon, 26 Aug, 12:26 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35845

  3. Benjamin Franzke uploaded patch set 2 08/26/19, 12:28

  4. TYPO3com voted on patch set 2 V -1 08/26/19, 12:38 Completed build in 09m 36s on Mon, 26 Aug, 12:38 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35846

  5. Benjamin Franzke uploaded patch set 3 08/26/19, 12:45

  6. TYPO3com voted on patch set 3 V -1 08/26/19, 12:45 Completed build in 12s on Mon, 26 Aug, 12:45 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35847

  7. Benjamin Franzke uploaded patch set 4 08/26/19, 12:54

  8. TYPO3com voted on patch set 4 V +1 08/26/19, 13:04 Completed build in 10m 25s on Mon, 26 Aug, 01:04 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35848

  9. Benjamin Franzke uploaded patch set 5 08/26/19, 15:15

  10. TYPO3com voted on patch set 5 V +1 08/26/19, 15:26 Completed build in 10m 27s on Mon, 26 Aug, 03:26 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35850

  11. Benjamin Franzke uploaded patch set 6 08/26/19, 19:02

  12. TYPO3com voted on patch set 6 V -1 08/26/19, 19:03 Completed build in 13s on Mon, 26 Aug, 07:03 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35853

  13. Benjamin Franzke uploaded patch set 7 08/26/19, 19:03

  1. TYPO3com voted on patch set 7 V -1 08/26/19, 19:13 Completed build in 10m 00s on Mon, 26 Aug, 07:13 PM Test Summary: 4770 of 47694 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35854

  2. Benjamin Franzke uploaded patch set 8 08/26/19, 19:20

  3. TYPO3com voted on patch set 8 V +1 08/26/19, 19:31 Completed build in 10m 43s on Mon, 26 Aug, 07:31 PM Test Summary: 47335 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35855

  4. Benjamin Franzke uploaded patch set 9 08/26/19, 21:59

  5. TYPO3com voted on patch set 9 V +1 08/26/19, 22:10 Completed build in 10m 42s on Mon, 26 Aug, 10:10 PM Test Summary: 47391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35859

  6. Benjamin Franzke uploaded patch set 10 08/27/19, 05:42

  7. TYPO3com voted on patch set 10 V -1 08/27/19, 05:56 Completed build in 13m 30s on Tue, 27 Aug, 05:56 AM Test Summary: 47391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35861

  8. Benjamin Franzke uploaded patch set 11 08/27/19, 11:39

  9. TYPO3com voted on patch set 11 V -1 08/27/19, 11:49 Completed build in 10m 05s on Tue, 27 Aug, 11:49 AM Test Summary: 1 of 47750 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35863

  10. TYPO3com voted on patch set 11 V +1 08/27/19, 12:10 Completed build in 09m 19s on Tue, 27 Aug, 12:10 PM Test Summary: 47391 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35864

  11. Benjamin Franzke uploaded patch set 12 08/28/19, 07:09

  12. TYPO3com voted on patch set 12 V -1 08/28/19, 07:20 Completed build in 11m 00s on Wed, 28 Aug, 07:20 AM Test Summary: 1 of 47773 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35874

  13. Benjamin Franzke uploaded patch set 13 08/28/19, 09:14

    Resolved Merge-Conflict
  14. Benjamin Franzke wrote 08/28/19, 09:15

    Description "Resolved Merge-Conflict" removed
  15. TYPO3com voted on patch set 13 V +1 08/28/19, 09:34 Completed build in 13m 28s on Wed, 28 Aug, 09:34 AM Test Summary: 47414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35883

  16. Benjamin Franzke uploaded patch set 14 09/04/19, 07:35

    Resolve Merge Conflict
  17. TYPO3com voted on patch set 14 V +1 09/04/19, 07:45 Completed build in 10m 01s on Wed, 4 Sep, 07:45 AM Test Summary: 47414 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36039

  18. Benjamin Franzke uploaded patch set 15 09/13/19, 17:30

  19. Benjamin Franzke updated the commit message in patch set 16 09/13/19, 17:34

  20. TYPO3com voted on patch set 15 V +1 09/13/19, 17:42 Completed build in 10m 56s on Fri, 13 Sep, 05:42 PM Test Summary: 47732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36438

  21. TYPO3com voted on patch set 16 V +1 09/13/19, 17:43 Completed build in 08m 56s on Fri, 13 Sep, 05:43 PM Test Summary: 47732 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36439

  22. Frank Nägler voted on patch set 16 CR +1 09/13/19, 18:07

  23. Benni Mack voted on patch set 16 V +1 CR +1 09/18/19, 17:19

  24. Frank Nägler voted on patch set 16 V +2 CR +2 09/20/19, 08:48

  25. Frank Nägler merged patch set 17 09/20/19, 08:48