Review main Merged

61559[TASK] Fix class namespace in php doc comment of JsonView

Daniel Siepmann CR +2 V +2 Normal +44 −44 updated 08/26/19, 22:00

Commit message

This would allow everyone else to copy and paste example.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Oliver Klee +1
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 1012

  1. Daniel Siepmann uploaded patch set 1 08/26/19, 16:01

  2. Daniel Siepmann wrote 08/26/19, 16:02

    Topic set to extbase
  3. TYPO3com voted on patch set 1 V +1 08/26/19, 16:12 Completed build in 11m 06s on Mon, 26 Aug, 04:12 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35851

  4. Alexander Schnitzler commented on patch set 1 08/26/19, 16:19

    Unresolved

    Let's rewrite this as "Fix class namespace in php doc comment of JsonView"
  5. Georg Ringer commented on patch set 1 V +1 CR +1 08/26/19, 17:58

    can we also use the shorthand syntax for arrays?
  6. Oliver Klee commented on patch set 1 08/26/19, 18:30

    Unresolved

    This also affects 9.5.
  7. Anja Leichsenring uploaded patch set 2 08/26/19, 21:01

  8. Anja Leichsenring voted on patch set 2 V +1 CR +1 08/26/19, 21:01

  9. TYPO3com voted on patch set 2 V +1 08/26/19, 21:12 Completed build in 10m 47s on Mon, 26 Aug, 09:12 PM Test Summary: 47227 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35858

  10. Oliver Klee voted on patch set 2 V +1 CR +1 08/26/19, 21:18

  11. Georg Ringer voted on patch set 2 V +2 CR +2 08/26/19, 22:00

  12. Georg Ringer merged patch set 3 08/26/19, 22:00