Review main Merged

61568[FEATURE] Allow multiple sitemaps in parallel

Markus Klein CR +2 V +2 Normal +102 −12 updated 10/25/19, 12:28

Commit message

Add the possibility to have config like this:

   seo_googlenews < seo_sitemap
   seo_googlenews.typeNum = 1571859552
   seo_googlenews.10.sitemapType = googleNewsSitemap

   plugin.tx_seo {
       config {
           xmlSitemap {
               sitemaps {
                   news {
                       provider = GeorgRinger\News\Seo\NewsXmlSitemapDataProvider
                       config {
                           ...
                       }
                   }
               }
           }
           googleNewsSitemap {
               sitemaps {
                   news {
                       provider = GeorgRinger\News\Seo\NewsXmlSitemapDataProvider
                       config {
                           googleNews = 1
                           ...
                           template = GoogleNewsXmlSitemap.html
                       }
                   }
               }
           }
       }
   }

Google sitemap: example.com/index.php?type=1571859552&sitemap=news

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Kevin Appelt +1
    • Johannes Kasberger +1
    • Jörg Bösche +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Johannes Kasberger +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 3856

Show 1831 earlier messages
  1. Markus Klein uploaded patch set 1 08/28/19, 13:36

  2. Markus Klein updated the commit message in patch set 2 08/28/19, 13:43

  3. Markus Klein uploaded patch set 3 08/28/19, 13:45

  4. Markus Klein uploaded patch set 4 08/28/19, 13:47

  5. TYPO3com voted on patch set 1 V +1 08/28/19, 13:47 Completed build in 11m 30s on Wed, 28 Aug, 01:47 PM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35887

  6. Markus Klein updated the commit message in patch set 5 08/28/19, 13:49

  7. TYPO3com voted on patch set 2 V +1 08/28/19, 13:55 Completed build in 12m 22s on Wed, 28 Aug, 01:55 PM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35888

  8. TYPO3com voted on patch set 3 V -1 08/28/19, 13:59 Completed build in 13m 13s on Wed, 28 Aug, 01:59 PM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35889

  9. TYPO3com voted on patch set 4 V -1 08/28/19, 14:03 Completed build in 13m 28s on Wed, 28 Aug, 02:03 PM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35890

  10. TYPO3com voted on patch set 5 V -1 08/28/19, 14:06 Completed build in 16m 46s on Wed, 28 Aug, 02:06 PM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35891

  11. Markus Klein uploaded patch set 6 08/28/19, 14:11

  12. TYPO3com voted on patch set 6 V -1 08/28/19, 14:25 Completed build in 13m 56s on Wed, 28 Aug, 02:25 PM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35894

  13. Markus Klein updated the commit message in patch set 7 08/28/19, 14:49

  14. Markus Klein commented on patch set 8 08/28/19, 14:50

    Published edit on patch set 7.
  15. TYPO3com voted on patch set 7 V -1 08/28/19, 14:59 Completed build in 10m 22s on Wed, 28 Aug, 02:59 PM Test Summary: 3 of 47597 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35897

  16. TYPO3com voted on patch set 8 V +1 08/28/19, 15:02 Completed build in 11m 25s on Wed, 28 Aug, 03:02 PM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35898

  17. Markus Klein updated the commit message in patch set 9 09/13/19, 21:52

  18. Markus Klein commented on patch set 9 09/13/19, 21:53

    This change is ready for review.
  19. TYPO3com voted on patch set 9 V -1 09/13/19, 22:01 Completed build in 08m 49s on Fri, 13 Sep, 10:01 PM Test Summary: 47547 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36446

  20. TYPO3com voted on patch set 9 V +1 09/13/19, 23:23 Completed build in 1h 39m 06s on Fri, 13 Sep, 11:23 PM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36446

  21. Markus Klein updated the commit message in patch set 10 09/17/19, 09:25

  22. TYPO3com voted on patch set 10 V +1 09/17/19, 09:35 Completed build in 10m 30s on Tue, 17 Sep, 09:35 AM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36491

  23. Markus Klein updated the commit message in patch set 11 09/17/19, 10:04

  24. TYPO3com voted on patch set 11 V +1 09/17/19, 10:15 Completed build in 10m 28s on Tue, 17 Sep, 10:15 AM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36497

  25. Markus Klein commented on patch set 11 CR -1 09/17/19, 12:48

    will adjust the rst docs too
  26. Guido Schmechel commented on patch set 11 10/12/19, 12:24

    Ping? :-)
  27. Markus Klein uploaded patch set 12 10/14/19, 11:35

  28. TYPO3com voted on patch set 12 V +1 10/14/19, 11:47 Completed build in 11m 32s on Mon, 14 Oct, 11:47 AM Test Summary: 47982 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37302

  29. Daniel Goerz commented on patch set 12 10/14/19, 12:12

    Shouldn't we then add seo_sitemap.10.sitemapType = xmlSitemap to the Typoscript of EXT:seo?
  30. Markus Klein commented on patch set 12 10/14/19, 12:20

    > Patch Set 12: > > Shouldn't we then add > > seo_sitemap.10.sitemapType = xmlSitemap > > to the Typoscript of EXT:seo? Not needed, this is the default value
  31. Daniel Goerz commented on patch set 12 10/14/19, 12:36

    > Patch Set 12: > > > Patch Set 12: > > > > Shouldn't we then add > > > > seo_sitemap.10.sitemapType = xmlSitemap > > > > to the Typoscript of EXT:seo? > > Not needed, this is the default value Ack. that it is not needed, I just thought it would then be clearer by reading the TS that sitemapType is a thing.
  1. Richard Haeser uploaded patch set 13 10/21/19, 13:28

  2. Richard Haeser voted on patch set 13 V +1 CR +1 10/21/19, 13:29

  3. TYPO3com voted on patch set 13 V +1 10/21/19, 13:38 Completed build in 10m 13s on Mon, 21 Oct, 01:38 PM Test Summary: 48010 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37417

  4. Markus Klein commented on patch set 13 CR -1 10/21/19, 15:14

    if it's a FEATURE then Releases is wrong and RST too
  5. Richard Haeser commented on patch set 13 CR -1 10/22/19, 08:59

    We decided this is a new feature and we will only include this in master. In previous versions you can add a separate sitemap easily with an extension. I will restructure RST for this.
  6. Richard Haeser uploaded patch set 14 10/22/19, 09:24

  7. TYPO3com voted on patch set 14 V +1 10/22/19, 09:33 Completed build in 08m 53s on Tue, 22 Oct, 09:33 AM Test Summary: 48014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37443

  8. Richard Haeser voted on patch set 14 V +1 CR +1 10/22/19, 09:36

  9. Richard Haeser updated the commit message in patch set 15 10/23/19, 18:32

  10. Richard Haeser voted on patch set 15 V +1 CR +1 10/23/19, 18:33

  11. TYPO3com voted on patch set 15 V +1 10/23/19, 18:42 Completed build in 10m 00s on Wed, 23 Oct, 06:42 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37536

  12. Kevin Appelt uploaded patch set 16 10/23/19, 19:59

  13. TYPO3com voted on patch set 16 V +1 10/23/19, 20:08 Completed build in 09m 46s on Wed, 23 Oct, 08:08 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37543

  14. Kevin Appelt voted on patch set 16 CR +1 10/23/19, 20:23

  15. Richard Haeser voted on patch set 16 V +1 CR +1 10/23/19, 20:28

  16. Richard Haeser commented on patch set 16 10/23/19, 20:29

    Markus, can you verify the patch still works for you? Only did some small changes.
  17. Markus Klein commented on patch set 16 10/23/19, 20:58

    Looks good to me
  18. Richard Haeser updated the commit message in patch set 17 10/23/19, 21:00

  19. Richard Haeser voted on patch set 17 V +1 CR +1 10/23/19, 21:00

  20. TYPO3com voted on patch set 17 V +1 10/23/19, 21:11 Completed build in 10m 43s on Wed, 23 Oct, 09:11 PM Test Summary: 48017 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-37547

  21. Kevin Appelt voted on patch set 17 CR +1 10/23/19, 21:14

  22. Jörg Bösche voted on patch set 17 CR +1 10/24/19, 06:39

  23. Johannes Kasberger voted on patch set 17 V +1 CR +1 10/25/19, 12:25

  24. Richard Haeser voted on patch set 17 V +2 CR +2 10/25/19, 12:28

  25. Richard Haeser merged patch set 18 10/25/19, 12:28