61572[TASK] Deprecate evaluation of ll-XML localization files
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Markus Klein +1
- Xavier Perseguers +1
-
Verified V +2 Done
- Benni Mack +2
- Markus Klein +1
- TYPO3com +1 CI
Issues 1
Files 10
- typo3/sysext/core/Classes/Localization/Parser/LocallangXmlParser.php1+6 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-89037-DeprecatedLocallangXmlParser.rst1new+31 −0
- typo3/sysext/core/Tests/Unit/Localization/LocalizationFactoryTest.php+0 −48
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallang.xmlrenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallangNumericKeys.xmlrenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallangOnlyDefaultLanguage.xmlrenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/Fixtures/locallang_override.xmlrenamed+0 −0
- typo3/sysext/core/Tests/UnitDeprecated/Localization/Parser/LocallangXmlParserTest.phprenamed+2 −1
- typo3/sysext/core/Tests/UnitDeprecated/Localization/LocalizationFactoryTest.phpnew+83 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/ClassNameMatcher.php1+5 −0
Review log 2540
Show 1115 earlier messages
-
Georg Ringer uploaded patch set 1 08/29/19, 03:55
-
Georg Ringer commented on patch set 1 08/29/19, 03:55
This change is ready for review. -
TYPO3com voted on patch set 1 V -1 08/29/19, 04:09 Completed build in 12m 35s on Thu, 29 Aug, 04:09 AM Test Summary: 23 of 47579 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35905
-
Xavier Perseguers commented on patch set 1 CR -1 08/29/19, 05:54
Thanks for finally deprecating this.Breaking-89037-DeprecateLocallangXmlParser.rst:12UnresolvedWe used to call this format "ll-XML" for "locallang-XML". I'd like to keep it this way as much as possible because XLIFF is an XML format as well, so just to be clear.Breaking-89037-DeprecateLocallangXmlParser.rst:18UnresolvedThis is de facto not a "standard", more a "format".Breaking-89037-DeprecateLocallangXmlParser.rst:24Unresolved... using ll-XML localization files.Breaking-89037-DeprecateLocallangXmlParser.rst:30Unresolved... the following configuration ... (mind missing "o")ClassNameMatcher.php:1332UnresolvedInvalid file: 'Breaking-89037-DeprecateLocallangXmlParser.rst' instead -
Chris Müller commented on patch set 1 CR -1 08/29/19, 06:58
Breaking-89037-DeprecateLocallangXmlParser.rst:30Unresolved... :file:`LocalConfiguration.php` ... (mind the uppercase C) -
Benjamin Franzke commented on patch set 1 CR -1 08/29/19, 08:20
"[TASK]" is missingLocallangXmlParser.php:25Unresolvedv10.1Breaking-89037-DeprecateLocallangXmlParser.rst:13Unresolved"previous support for locallang-XML" -
Georg Ringer uploaded patch set 2 08/29/19, 16:54
-
TYPO3com voted on patch set 2 V -1 08/29/19, 17:04 Completed build in 10m 14s on Thu, 29 Aug, 05:04 PM Test Summary: 22 of 47581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35938
-
Georg Ringer uploaded patch set 3 08/29/19, 17:48
-
TYPO3com voted on patch set 3 V -1 08/29/19, 17:57 Completed build in 09m 28s on Thu, 29 Aug, 05:57 PM Test Summary: 17 of 47581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35939
-
Georg Ringer uploaded patch set 4 08/30/19, 07:17
-
Xavier Perseguers voted on patch set 4 CR +1 08/30/19, 07:26
-
TYPO3com voted on patch set 4 V -1 08/30/19, 07:35 Completed build in 17m 14s on Fri, 30 Aug, 07:35 AM Test Summary: 4 of 47581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35947
-
Andreas Kienast commented on patch set 4 08/30/19, 10:13
We wanted to avoid breaking changes after the 10.0 release. Is there no way to deprecated this in a sane way instead? -
Georg Ringer uploaded patch set 5 08/31/19, 11:30
-
TYPO3com voted on patch set 5 V -1 08/31/19, 11:40 Completed build in 09m 37s on Sat, 31 Aug, 11:40 AM Test Summary: 47230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35967
-
Georg Ringer uploaded patch set 6 08/31/19, 18:40
-
TYPO3com voted on patch set 6 V -1 08/31/19, 18:50 Completed build in 09m 58s on Sat, 31 Aug, 06:50 PM Test Summary: 1 of 47589 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35972
-
Georg Ringer uploaded patch set 7 09/01/19, 05:08
-
TYPO3com voted on patch set 7 V +1 09/01/19, 05:18 Completed build in 10m 04s on Sun, 1 Sep, 05:18 AM Test Summary: 47230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35973
-
Georg Ringer uploaded patch set 8 09/02/19, 09:03
-
TYPO3com voted on patch set 8 V -1 09/02/19, 09:03 Completed build in 11s on Mon, 2 Sep, 09:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35983
-
Georg Ringer uploaded patch set 9 09/02/19, 11:50
-
TYPO3com voted on patch set 9 V -1 09/02/19, 12:00 Completed build in 10m 16s on Mon, 2 Sep, 12:00 PM Test Summary: 4 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35992
-
Andreas Kienast uploaded patch set 10 09/02/19, 12:15
-
TYPO3com voted on patch set 10 V +1 09/02/19, 12:24 Completed build in 09m 07s on Mon, 2 Sep, 12:24 PM Test Summary: 47232 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35993
-
Markus Klein updated the commit message in patch set 11 09/02/19, 19:41
-
TYPO3com voted on patch set 11 V +1 09/02/19, 19:51 Completed build in 10m 09s on Mon, 2 Sep, 07:51 PM Test Summary: 47232 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35999
-
Markus Klein commented on patch set 12 09/02/19, 20:00
Published edit on patch set 11. -
Markus Klein commented on patch set 12 CR -1 09/02/19, 20:01
Deprecation-89037-DeprecatedLocallangXmlParser.rst:18UnresolvedThat's not true, right? Otherwise this would be breaking. -
TYPO3com voted on patch set 12 V -1 09/02/19, 20:10 Completed build in 09m 49s on Mon, 2 Sep, 08:10 PM Test Summary: 47232 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36000
-
Georg Ringer uploaded patch set 13 09/03/19, 07:47
-
TYPO3com voted on patch set 13 V -1 09/03/19, 07:57 Completed build in 09m 20s on Tue, 3 Sep, 07:57 AM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36010
-
Markus Klein commented on patch set 14 09/03/19, 10:53
Published edit on patch set 13. -
TYPO3com voted on patch set 14 V -1 09/03/19, 11:03 Completed build in 10m 05s on Tue, 3 Sep, 11:03 AM Test Summary: 46999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36019
-
TYPO3com voted on patch set 14 V +1 09/03/19, 11:10 Completed build in 27m 05s on Tue, 3 Sep, 11:10 AM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36019
-
Markus Klein voted on patch set 14 V +1 CR +1 09/03/19, 11:11
-
Xavier Perseguers commented on patch set 14 CR +1 09/03/19, 11:28
Reply
Done -
Benni Mack voted on patch set 14 V +2 CR +2 09/03/19, 11:30
-
Benni Mack merged patch set 15 09/03/19, 11:30