Review main Merged

61572[TASK] Deprecate evaluation of ll-XML localization files

Georg Ringer CR +2 V +2 Normal +127 −49 updated 09/03/19, 11:30

Commit message

Deprecate the usage of LocallangXmlParser in favor of xlf.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • Xavier Perseguers +1
  • Verified V +2 Done
    • Benni Mack +2
    • Markus Klein +1
    • TYPO3com +1 CI

Issues 1

Files 10

Review log 2540

Show 1115 earlier messages
  1. Georg Ringer uploaded patch set 1 08/29/19, 03:55

  2. Georg Ringer commented on patch set 1 08/29/19, 03:55

    This change is ready for review.
  3. TYPO3com voted on patch set 1 V -1 08/29/19, 04:09 Completed build in 12m 35s on Thu, 29 Aug, 04:09 AM Test Summary: 23 of 47579 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35905

  4. Xavier Perseguers commented on patch set 1 CR -1 08/29/19, 05:54

    Thanks for finally deprecating this.

    Breaking-89037-DeprecateLocallangXmlParser.rst:12 Unresolved

    We used to call this format "ll-XML" for "locallang-XML". I'd like to keep it this way as much as possible because XLIFF is an XML format as well, so just to be clear.

    Breaking-89037-DeprecateLocallangXmlParser.rst:18 Unresolved

    This is de facto not a "standard", more a "format".

    Breaking-89037-DeprecateLocallangXmlParser.rst:24 Unresolved

    ... using ll-XML localization files.

    Breaking-89037-DeprecateLocallangXmlParser.rst:30 Unresolved

    ... the following configuration ... (mind missing "o")

    ClassNameMatcher.php:1332 Unresolved

    Invalid file: 'Breaking-89037-DeprecateLocallangXmlParser.rst' instead
  5. Chris Müller commented on patch set 1 CR -1 08/29/19, 06:58

    Breaking-89037-DeprecateLocallangXmlParser.rst:30 Unresolved

    ... :file:`LocalConfiguration.php` ... (mind the uppercase C)
  6. Benjamin Franzke commented on patch set 1 CR -1 08/29/19, 08:20

    "[TASK]" is missing

    LocallangXmlParser.php:25 Unresolved

    v10.1

    Breaking-89037-DeprecateLocallangXmlParser.rst:13 Unresolved

    "previous support for locallang-XML"
  7. Georg Ringer uploaded patch set 2 08/29/19, 16:54

  8. TYPO3com voted on patch set 2 V -1 08/29/19, 17:04 Completed build in 10m 14s on Thu, 29 Aug, 05:04 PM Test Summary: 22 of 47581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35938

  9. Georg Ringer uploaded patch set 3 08/29/19, 17:48

  10. TYPO3com voted on patch set 3 V -1 08/29/19, 17:57 Completed build in 09m 28s on Thu, 29 Aug, 05:57 PM Test Summary: 17 of 47581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35939

  11. Georg Ringer uploaded patch set 4 08/30/19, 07:17

  12. Xavier Perseguers voted on patch set 4 CR +1 08/30/19, 07:26

  13. TYPO3com voted on patch set 4 V -1 08/30/19, 07:35 Completed build in 17m 14s on Fri, 30 Aug, 07:35 AM Test Summary: 4 of 47581 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35947

  14. Andreas Kienast commented on patch set 4 08/30/19, 10:13

    We wanted to avoid breaking changes after the 10.0 release. Is there no way to deprecated this in a sane way instead?
  15. Georg Ringer uploaded patch set 5 08/31/19, 11:30

  1. TYPO3com voted on patch set 5 V -1 08/31/19, 11:40 Completed build in 09m 37s on Sat, 31 Aug, 11:40 AM Test Summary: 47230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35967

  2. Georg Ringer uploaded patch set 6 08/31/19, 18:40

  3. TYPO3com voted on patch set 6 V -1 08/31/19, 18:50 Completed build in 09m 58s on Sat, 31 Aug, 06:50 PM Test Summary: 1 of 47589 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35972

  4. Georg Ringer uploaded patch set 7 09/01/19, 05:08

  5. TYPO3com voted on patch set 7 V +1 09/01/19, 05:18 Completed build in 10m 04s on Sun, 1 Sep, 05:18 AM Test Summary: 47230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35973

  6. Georg Ringer uploaded patch set 8 09/02/19, 09:03

  7. TYPO3com voted on patch set 8 V -1 09/02/19, 09:03 Completed build in 11s on Mon, 2 Sep, 09:03 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35983

  8. Georg Ringer uploaded patch set 9 09/02/19, 11:50

  9. TYPO3com voted on patch set 9 V -1 09/02/19, 12:00 Completed build in 10m 16s on Mon, 2 Sep, 12:00 PM Test Summary: 4 of 47593 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35992

  10. Andreas Kienast uploaded patch set 10 09/02/19, 12:15

  11. TYPO3com voted on patch set 10 V +1 09/02/19, 12:24 Completed build in 09m 07s on Mon, 2 Sep, 12:24 PM Test Summary: 47232 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35993

  12. Markus Klein updated the commit message in patch set 11 09/02/19, 19:41

  13. TYPO3com voted on patch set 11 V +1 09/02/19, 19:51 Completed build in 10m 09s on Mon, 2 Sep, 07:51 PM Test Summary: 47232 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35999

  14. Markus Klein commented on patch set 12 09/02/19, 20:00

    Published edit on patch set 11.
  15. Markus Klein commented on patch set 12 CR -1 09/02/19, 20:01

    Deprecation-89037-DeprecatedLocallangXmlParser.rst:18 Unresolved

    That's not true, right? Otherwise this would be breaking.
  16. TYPO3com voted on patch set 12 V -1 09/02/19, 20:10 Completed build in 09m 49s on Mon, 2 Sep, 08:10 PM Test Summary: 47232 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36000

  17. Georg Ringer uploaded patch set 13 09/03/19, 07:47

  18. TYPO3com voted on patch set 13 V -1 09/03/19, 07:57 Completed build in 09m 20s on Tue, 3 Sep, 07:57 AM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36010

  19. Markus Klein commented on patch set 14 09/03/19, 10:53

    Published edit on patch set 13.
  20. TYPO3com voted on patch set 14 V -1 09/03/19, 11:03 Completed build in 10m 05s on Tue, 3 Sep, 11:03 AM Test Summary: 46999 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36019

  21. TYPO3com voted on patch set 14 V +1 09/03/19, 11:10 Completed build in 27m 05s on Tue, 3 Sep, 11:10 AM Test Summary: 47238 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36019

  22. Markus Klein voted on patch set 14 V +1 CR +1 09/03/19, 11:11

  23. Xavier Perseguers commented on patch set 14 CR +1 09/03/19, 11:28

    Reply

    Done
  24. Benni Mack voted on patch set 14 V +2 CR +2 09/03/19, 11:30

  25. Benni Mack merged patch set 15 09/03/19, 11:30