Review main Merged

61573[BUGFIX] Allow selective saving in SiteConfiguration

Susi Moog CR +2 V +2 Normal +208 −17 updated 09/07/19, 11:20

Commit message

YAML SiteConfiguration allows imports and custom configuration
that is not configurable via UI to be written directly into the
configuration files, however, when saving with the UI these
settings are overwritten and resolved. This change changes the
SiteConfiguration in a way, that only modified values are written
and imports are completely left as they are.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Torben Hansen +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Torben Hansen +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 2131

Show 46 earlier messages
  1. Susi Moog uploaded patch set 1 08/29/19, 10:43

  2. Benni Mack commented on patch set 1 08/29/19, 10:47

    This change is ready for review.

    SiteConfiguration.php:170

    that's actually a bug. if the folder exists, but the file doesn't it's not necessary to execute mkdir_deep().

    SiteConfiguration.php:261

    don't!
  3. TYPO3com voted on patch set 1 V -1 08/29/19, 10:53 Completed build in 09m 49s on Thu, 29 Aug, 10:53 AM Test Summary: 487 of 47603 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35914

  4. Susi Moog uploaded patch set 2 08/29/19, 12:37

  5. Susi Moog marked it work in progress 08/29/19, 12:37

  6. TYPO3com voted on patch set 2 V -1 08/29/19, 12:47 Completed build in 09m 33s on Thu, 29 Aug, 12:47 PM Test Summary: 441 of 47603 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35920

  1. Susi Moog uploaded patch set 3 08/29/19, 12:51

  2. TYPO3com voted on patch set 3 V +1 08/29/19, 13:01 Completed build in 10m 22s on Thu, 29 Aug, 01:01 PM Test Summary: 47244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35921

  3. Susi Moog updated the commit message in patch set 4 08/29/19, 16:22

  4. Susi Moog commented on patch set 4 08/29/19, 16:24

    SiteConfiguration.php:170 Reply Unresolved

    changed to check the folder instead.

    SiteConfiguration.php:261 Reply Unresolved

    it's necessary for the arrayMergeRecursiveWithOverrule.
  5. TYPO3com voted on patch set 4 V -1 08/29/19, 16:33 Completed build in 10m 30s on Thu, 29 Aug, 04:33 PM Test Summary: 46998 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35936

  6. Torben Hansen commented on patch set 4 V +1 09/01/19, 17:46

    Works as expected and imports in yaml files remain after saving site configuration in sites module. I would consider this patch as a bugfix, since it may not have been intended to overwrite imports on save and the current issue may be a blocker for users to update to v9.5
  7. TYPO3com voted on patch set 4 V +1 09/02/19, 07:21 Completed build in 15h 08m 42s on Mon, 2 Sep, 07:21 AM Test Summary: 47244 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35936

  8. Daniel Hoffmann voted on patch set 4 V +1 09/04/19, 11:18

  9. Susi Moog uploaded patch set 5 09/06/19, 11:10

  10. Susi Moog uploaded patch set 6 09/06/19, 11:11

  11. TYPO3com voted on patch set 5 V +1 09/06/19, 11:20 Completed build in 09m 58s on Fri, 6 Sep, 11:20 AM Test Summary: 47373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36128

  12. TYPO3com voted on patch set 6 V +1 09/06/19, 11:24 Completed build in 11m 14s on Fri, 6 Sep, 11:24 AM Test Summary: 47373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36129

  13. Susi Moog uploaded patch set 7 09/06/19, 11:28

  14. Susi Moog commented on patch set 7 09/06/19, 11:29

    This change is ready for review.
  15. TYPO3com commented on patch set 7 09/06/19, 11:36 Completed build in 08m 14s on Fri, 6 Sep, 11:36 AM Test Summary: 47373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36131

  16. Andreas Kienast voted on patch set 7 V +1 CR +1 09/06/19, 11:56

  17. Andreas Kienast commented on patch set 7 V -1 CR 0 09/06/19, 11:56

    Darn. I fail to delete site languages with this patch applied.
  18. Andreas Kienast uploaded patch set 8 09/06/19, 12:06

  19. TYPO3com voted on patch set 8 V -1 09/06/19, 12:16 Completed build in 10m 08s on Fri, 6 Sep, 12:16 PM Test Summary: 4 of 47444 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36138

  20. Andreas Kienast uploaded patch set 9 09/06/19, 13:03

  21. TYPO3com voted on patch set 9 V +1 09/06/19, 13:14 Completed build in 10m 57s on Fri, 6 Sep, 01:14 PM Test Summary: 47373 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36141

  22. Richard Haeser voted on patch set 9 V +1 CR +1 09/06/19, 15:10

  23. Torben Hansen voted on patch set 9 V +1 CR +1 09/07/19, 10:25

  24. Richard Haeser voted on patch set 9 V +2 CR +2 09/07/19, 11:20

  25. Richard Haeser merged patch set 10 09/07/19, 11:20