Review main Merged

61575[TASK] Upgrade asset build stack

Andreas Kienast CR +2 V +2 Expert +1252 −1170 updated 08/29/19, 14:48

Commit message

Some tools used to build assets have been updated to recent versions. In
the same run, the assets have benn rebuilt.

For future tasks, uglifyjs is replaced with terserjs.

Executed commands:

  yarn remove grunt-contrib-uglify
  yarn add --dev grunt-terser
  yarn add --dev grunt-contrib-imagemin@^3.1
  grunt build

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 137

Show 117 more files

Review log 1114

  1. Andreas Kienast uploaded patch set 1 08/29/19, 11:45

  2. TYPO3com voted on patch set 1 V +1 08/29/19, 11:55 Completed build in 10m 04s on Thu, 29 Aug, 11:55 AM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35919

  3. Andreas Kienast commented on patch set 1 CR -2 08/29/19, 12:31

    It seems uglify is still unable to minify ES6 builds.
  4. Andreas Kienast uploaded patch set 2 08/29/19, 13:12

  5. Andreas Kienast voted on patch set 2 CR 0 08/29/19, 13:12

  6. TYPO3com voted on patch set 2 V +1 08/29/19, 13:21 Completed build in 09m 32s on Thu, 29 Aug, 01:21 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35922

  7. Frank Nägler voted on patch set 2 CR +1 08/29/19, 13:22

  8. Frank Nägler voted on patch set 2 V +1 08/29/19, 13:26

  9. Benjamin Franzke commented on patch set 2 08/29/19, 13:37

    This uglify upgrade command should be removed, looks like a left-over from the first patchset.

    package.json:44 Unresolved

    Looks like yarn add --dev grunt-contrib-imagemin@^3.1 is missing in the list of executed commands.
  10. Benjamin Franzke updated the commit message in patch set 3 08/29/19, 13:39

  11. TYPO3com voted on patch set 3 V +1 08/29/19, 13:50 Completed build in 10m 39s on Thu, 29 Aug, 01:50 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35925

  12. Andreas Kienast commented on patch set 3 08/29/19, 13:59

    Reply Unresolved

    Meh, I had that in patch set 1. Thanks for fixing
  13. Frank Nägler voted on patch set 3 V +2 CR +2 08/29/19, 14:48

  14. Frank Nägler merged patch set 4 08/29/19, 14:48