Review main Merged

61577[BUGFIX] Set rel="noopener noreferrer" for external links

Frank Nägler CR +2 V +2 Normal +33 −33 updated 11/23/19, 15:33

Commit message

This patch adds rel="noopener noreferrer" for external links in
backend and install tool for security reasons.
If this is not set, the other page can access the window object
with the window.opener property.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Guido Schmechel +1
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 1012

  1. Frank Nägler uploaded patch set 1 08/29/19, 14:22

  2. Guido Schmechel commented on patch set 1 08/29/19, 14:26

    Unresolved

    Small typo. Maybe we can also add a short info why we add these attributes?
  3. TYPO3com voted on patch set 1 V -1 08/29/19, 14:33 Completed build in 10m 53s on Thu, 29 Aug, 02:33 PM Test Summary: 47230 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35929

  4. Frank Nägler updated the commit message in patch set 2 08/29/19, 14:33

  5. TYPO3com voted on patch set 2 V +1 08/29/19, 14:42 Completed build in 09m 09s on Thu, 29 Aug, 02:42 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35931

  6. Guido Schmechel voted on patch set 2 V +1 CR +1 08/29/19, 22:42

  7. Andreas Kienast voted on patch set 2 V +2 CR +2 08/30/19, 06:51

  8. Andreas Kienast merged patch set 3 08/30/19, 06:51

  9. Benni Mack commented on patch set 3 09/02/19, 11:39

    AFAIK setting "noreferrer" sets "noopener" implictly, so setting "noreferrer" is enough. https://html.spec.whatwg.org/multipage/links.html#link-type-noreferrer
  10. Frank Nägler commented on patch set 3 09/02/19, 12:03

    > AFAIK setting "noreferrer" sets "noopener" implictly, so setting "noreferrer" is enough. That is new for me, but both versions look valid. What is your opinion? new patch to change this or not?
  11. Benni Mack commented on patch set 3 10/30/19, 09:08

    > Patch Set 3: > > > AFAIK setting "noreferrer" sets "noopener" implictly, so setting "noreferrer" is enough. > That is new for me, but both versions look valid. > What is your opinion? new patch to change this or not? I suggest we just use "noreferrer", this way the HTML is slower: https://web.dev/external-anchors-use-rel-noopener#how-to-improve-your-site's-performance-and-prevent-security-vulnerabilities
  12. Benni Mack commented on patch set 3 11/23/19, 15:33

    > Patch Set 3: > > > AFAIK setting "noreferrer" sets "noopener" implictly, so setting "noreferrer" is enough. > That is new for me, but both versions look valid. > What is your opinion? new patch to change this or not? https://review.typo3.org/c/Packages/TYPO3.CMS/+/62421