Review main Merged

61578[BUGFIX] Fix IRRE uniqueness flaws

Susi Moog CR +2 V +2 Normal +75 −15 updated 09/11/19, 13:41

Commit message

This patch fixes some flaws in the IRRE uniqueness handling:

- Validation is triggered once a record has been removed from DOM
- Removed records are now added to their selector again if not opened
  before
- Uniqueness handling now works for records with uid "0", which is
  relevant for a site's language handling
- The unique update is now triggered only when the value of its selector
  in a record actually changes

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Susi Moog +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 4

Review log 2741

Show 1016 earlier messages
  1. Susi Moog uploaded patch set 1 08/29/19, 16:03

  2. TYPO3com voted on patch set 1 V +1 08/29/19, 16:12 Completed build in 09m 21s on Thu, 29 Aug, 04:12 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35935

  3. Andreas Kienast uploaded patch set 2 08/29/19, 16:33

  4. TYPO3com voted on patch set 2 V +1 08/29/19, 16:43 Completed build in 09m 27s on Thu, 29 Aug, 04:43 PM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35937

  5. Susi Moog updated the commit message in patch set 3 08/29/19, 18:17

  6. TYPO3com voted on patch set 3 V -1 08/29/19, 18:26 Completed build in 09m 07s on Thu, 29 Aug, 06:26 PM Test Summary: 47001 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35940

  7. TYPO3com voted on patch set 3 V +1 08/30/19, 06:14 Completed build in 12h 06m 21s on Fri, 30 Aug, 06:14 AM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35940

  8. Oliver Klee commented on patch set 3 08/30/19, 09:25

    Unresolved

    According to the ticket, 9.5 is affected as well.
  9. Susi Moog updated the commit message in patch set 4 09/02/19, 09:45

  10. TYPO3com voted on patch set 4 V +1 09/02/19, 09:55 Completed build in 10m 22s on Mon, 2 Sep, 09:55 AM Test Summary: 47252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35985

  11. Andreas Kienast uploaded patch set 5 09/04/19, 14:47

  12. TYPO3com voted on patch set 5 V -1 09/04/19, 14:57 Completed build in 10m 44s on Wed, 4 Sep, 02:57 PM Test Summary: 47114 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36064

  13. Andreas Kienast commented on patch set 5 CR -2 09/05/19, 06:25

    There are still some issues, will check the IRRE implementation again.
  14. Andreas Kienast uploaded patch set 6 09/05/19, 07:20

  15. Andreas Kienast voted on patch set 6 CR 0 09/05/19, 07:20

  16. Andreas Kienast uploaded patch set 7 09/05/19, 07:30

  1. TYPO3com voted on patch set 6 V -1 09/05/19, 07:33 Completed build in 12m 22s on Thu, 5 Sep, 07:33 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36078

  2. TYPO3com voted on patch set 7 V +1 09/05/19, 08:01 Completed build in 28m 27s on Thu, 5 Sep, 08:01 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36081

  3. Andreas Kienast uploaded patch set 8 09/05/19, 08:12

  4. Andreas Kienast updated the commit message in patch set 9 09/05/19, 08:16

  5. TYPO3com voted on patch set 8 V +1 09/05/19, 08:23 Completed build in 10m 31s on Thu, 5 Sep, 08:23 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36084

  6. TYPO3com voted on patch set 9 V +1 09/05/19, 08:28 Completed build in 11m 27s on Thu, 5 Sep, 08:28 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36085

  7. Susi Moog commented on patch set 9 09/05/19, 08:37

    This change is ready for review.
  8. Susi Moog commented on patch set 9 V -1 09/08/19, 13:25

    There is something weird happening with the site language test case. If I remove the default language and add another language instead, I can save, but upon saving, the default language IRRE element is readded and fails validation then.
  9. Andreas Kienast commented on patch set 9 09/09/19, 07:02

    > Patch Set 9: Verified-1 > > If I remove the default language and add another language instead, I can save, but upon saving, the default language IRRE element is readded and fails validation then. I think the validation fails as you have to provide values as "Title" and "Locale" to the default language. Re-adding language 0 is done once the edit form opens and seems to be some kind of automagic.
  10. Susi Moog commented on patch set 9 09/09/19, 07:45

  11. Andreas Kienast uploaded patch set 10 09/10/19, 09:43

  12. Susi Moog voted on patch set 10 V +1 CR +1 09/10/19, 09:46

  13. TYPO3com voted on patch set 10 V -1 09/10/19, 09:55 Completed build in 11m 54s on Tue, 10 Sep, 09:55 AM Test Summary: 1 of 47793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36244

  14. TYPO3com commented on patch set 10 09/10/19, 09:58 Completed build in 26m 36s on Tue, 10 Sep, 09:58 AM Test Summary: 1 of 47793 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36244

  15. Andreas Kienast uploaded patch set 11 09/10/19, 10:05

  16. TYPO3com voted on patch set 11 V +1 09/10/19, 10:16 Completed build in 11m 30s on Tue, 10 Sep, 10:16 AM Test Summary: 47434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36245

  17. Frank Nägler voted on patch set 11 CR +1 09/10/19, 14:00

  18. Oliver Hader voted on patch set 11 CR +1 09/10/19, 14:26

  19. Andreas Kienast uploaded patch set 12 09/11/19, 05:50

  20. Susi Moog voted on patch set 12 CR +1 09/11/19, 05:57

  21. Susi Moog voted on patch set 12 V +1 09/11/19, 05:57

  22. TYPO3com voted on patch set 12 V +1 09/11/19, 06:02 Completed build in 11m 50s on Wed, 11 Sep, 06:02 AM Test Summary: 47458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36275

  23. Frank Nägler voted on patch set 12 CR +1 09/11/19, 09:54

  24. Frank Nägler voted on patch set 12 V +2 CR +2 09/11/19, 13:40

  25. Frank Nägler merged patch set 13 09/11/19, 13:41