Review TYPO3_8-7 Merged

61579[BUGFIX] Set rel="noopener noreferrer" for external links

Frank Nägler CR +2 V +2 Easy +20 −20 updated 08/30/19, 07:49

Commit message

This patch adds rel="noopener noreferrer" for external links in
backend and install tool for security reasons.
If this is not set, the other page can access the window object
with the window.opener property.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 46

  1. Frank Nägler uploaded patch set 1 08/30/19, 07:10

  2. Frank Nägler uploaded patch set 2 08/30/19, 07:13

  3. TYPO3com voted on patch set 1 V -1 08/30/19, 07:23 Completed build in 12m 44s on Fri, 30 Aug, 07:23 AM Test Summary: 80297 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3619

  4. TYPO3com voted on patch set 2 V +1 08/30/19, 07:25 Completed build in 12m 05s on Fri, 30 Aug, 07:25 AM Test Summary: 80400 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC87-3620

  5. Andreas Kienast voted on patch set 2 V +2 CR +2 08/30/19, 07:49

  6. Andreas Kienast merged patch set 3 08/30/19, 07:49