Review 9.5 Merged

61580[BUGFIX] Correctly renumber sorting values for value 0

Daniel Goerz CR +2 V +2 Normal +51 −49 updated 08/30/19, 09:58

Commit message

The called method reorders all elements not including
the given sorting number, leading to an off by one error
when the element in question has sorting number 0.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
  • Verified V +2 Done
    • Daniel Goerz +2
    • TYPO3com +1 CI

Issues 1

Files 18

Review log 46

  1. Daniel Goerz uploaded patch set 1 08/30/19, 07:39

  2. TYPO3com voted on patch set 1 V +1 08/30/19, 07:52 Completed build in 12m 35s on Fri, 30 Aug, 07:52 AM Test Summary: 50582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1079

  3. Daniel Goerz uploaded patch set 2 08/30/19, 07:53

  4. TYPO3com voted on patch set 2 V +1 08/30/19, 08:13 Completed build in 18m 02s on Fri, 30 Aug, 08:13 AM Test Summary: 50582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1081

  5. Daniel Goerz voted on patch set 2 V +2 CR +2 08/30/19, 09:58

  6. Daniel Goerz merged patch set 3 08/30/19, 09:58