Review main Merged

61581[BUGFIX] Restore original page tree after filter reset

Andreas Kienast CR +2 V +2 Easy +27 −11 updated 08/30/19, 10:48

Commit message

When a filter is applied to the page tree, the original state of the
tree is stored. When the filter is cleared, that stored state is
recovered.

Additionally, a regex check is fixed that falsely is positive for
undefined values.

Review

  • Code review CR +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Richard Haeser +1
  • Verified V +2 Done
    • Frank Nägler +2
    • Oli Bartsch +1
    • Richard Haeser +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 79

  1. Andreas Kienast uploaded patch set 1 08/30/19, 08:03

  2. Andreas Kienast uploaded patch set 2 08/30/19, 08:05

  3. Andreas Kienast uploaded patch set 3 08/30/19, 08:06

  4. TYPO3com voted on patch set 3 V -1 08/30/19, 08:17 Completed build in 09m 51s on Fri, 30 Aug, 08:17 AM Test Summary: 10 of 47599 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35950

  5. TYPO3com voted on patch set 3 V +1 08/30/19, 08:20 Completed build in 22m 44s on Fri, 30 Aug, 08:20 AM Test Summary: 47240 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35950

  6. Oli Bartsch voted on patch set 3 V +1 CR +1 08/30/19, 08:55

  7. Frank Nägler voted on patch set 3 V +2 CR +2 08/30/19, 10:46

  8. Frank Nägler merged patch set 4 08/30/19, 10:46

  9. Richard Haeser commented on patch set 4 V +1 CR +1 08/30/19, 10:48

    A too late :P But tested with page-tree of 3k pages and works fine.