61585[BUGFIX] Respect site for route persisted mappers
Commit message
Review
-
Code review CR +2 Done
- Oliver Hader +2
- Benni Mack +1
-
Verified V +2 Done
- Oliver Hader +2
- Jonas Eberle +1
- Benni Mack +1
- TYPO3com +1 CI
Issues 1
Files 13
- typo3/sysext/core/Classes/Routing/Aspect/AspectFactory.php2+15 −8
- typo3/sysext/core/Classes/Routing/Aspect/AspectTrait.phpnew+39 −0
- typo3/sysext/core/Classes/Routing/Aspect/PersistedAliasMapper.php3+15 −1
- typo3/sysext/core/Classes/Routing/Aspect/PersistedPatternMapper.php+15 −1
- typo3/sysext/core/Classes/Routing/Aspect/SiteAccessorTrait.php1new+108 −0
- typo3/sysext/core/Classes/Routing/PageRouter.php+2 −1
- typo3/sysext/core/Classes/Site/SiteAwareInterface.phpnew+33 −0
- typo3/sysext/core/Documentation/Changelog/9.5.x/Important-88720-RespectSiteForPersistedMappers.rstnew+24 −0
- typo3/sysext/core/Tests/Functional/Routing/Aspect/Fixtures/AspectScenario.yaml+27 −3
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedAliasMapperTest.php+120 −55
- typo3/sysext/core/Tests/Functional/Routing/Aspect/PersistedPatternMapperTest.phpnew+335 −0
- typo3/sysext/core/Tests/Unit/Routing/Aspect/AspectFactoryTest.php+15 −3
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodArgumentRequiredMatcher.php2+7 −0
Review log 4162
Show 2237 earlier messages
-
Helmut Hummel uploaded patch set 1 08/30/19, 12:11
-
TYPO3com voted on patch set 1 V -1 08/30/19, 12:11 Completed build in 11s on Fri, 30 Aug, 12:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35960
-
Helmut Hummel uploaded patch set 2 08/30/19, 12:13
-
TYPO3com voted on patch set 2 V -1 08/30/19, 12:22 Completed build in 09m 20s on Fri, 30 Aug, 12:22 PM Test Summary: 388 of 47607 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35961
-
Helmut Hummel uploaded patch set 3 08/30/19, 12:24
-
Mathias Brodala commented on patch set 3 08/30/19, 12:27
-
TYPO3com voted on patch set 3 V -1 08/30/19, 12:35 Completed build in 11m 03s on Fri, 30 Aug, 12:35 PM Test Summary: 328 of 47607 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35962
-
Helmut Hummel commented on patch set 3 08/30/19, 13:06
AspectFactory.php:113Reply UnresolvedWhile I agree, I just copied the current behaviour from SiteLanguageAwareTrait -
Helmut Hummel uploaded patch set 4 08/30/19, 13:21
-
TYPO3com voted on patch set 4 V -1 08/30/19, 13:21 Completed build in 12s on Fri, 30 Aug, 01:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35963
-
Helmut Hummel uploaded patch set 5 08/30/19, 13:36
-
TYPO3com voted on patch set 5 V -1 08/30/19, 13:47 Completed build in 10m 44s on Fri, 30 Aug, 01:47 PM Test Summary: 148 of 47607 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35965
-
Helmut Hummel uploaded patch set 6 08/31/19, 13:57
-
TYPO3com voted on patch set 6 V -1 08/31/19, 14:07 Completed build in 10m 26s on Sat, 31 Aug, 02:07 PM Test Summary: 1 of 37642 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35968
-
TYPO3com voted on patch set 6 V +1 08/31/19, 14:21 Completed build in 09m 51s on Sat, 31 Aug, 02:21 PM Test Summary: 47248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35969
-
Helmut Hummel uploaded patch set 7 08/31/19, 14:21
-
TYPO3com voted on patch set 7 V -1 08/31/19, 14:21 Completed build in 06s on Sat, 31 Aug, 02:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35970
-
Helmut Hummel uploaded patch set 8 08/31/19, 14:24
-
TYPO3com voted on patch set 8 V +1 08/31/19, 14:36 Completed build in 11m 50s on Sat, 31 Aug, 02:36 PM Test Summary: 47248 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35971
-
Helmut Hummel uploaded patch set 9 02/27/20, 15:30
-
TYPO3com voted on patch set 9 V -1 02/27/20, 15:40 Completed build in 10m 35s on Thu, 27 Feb, 03:40 PM Test Summary: 252 of 72481 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-744
-
Helmut Hummel uploaded patch set 10 02/28/20, 12:01
-
TYPO3com voted on patch set 10 V -1 02/28/20, 12:01 Completed build in 09s on Fri, 28 Feb, 12:01 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-785
-
Helmut Hummel uploaded patch set 11 02/28/20, 12:02
-
TYPO3com voted on patch set 11 V +1 02/28/20, 12:16 Completed build in 10m 32s on Fri, 28 Feb, 12:16 PM Test Summary: 72051 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-786
-
Oliver Hader commented on patch set 11 03/10/20, 10:09
→ https://review.typo3.org/c/Packages/TYPO3.CMS/+/63644 what do you think in general about having the possibility to resolve the parent Site from a SiteLanguage instance This way, we could avoid introducing new interfaces (since SiteLanguage needs to be given anyway) and would use Site & SiteLanguage "as a whole" structure... -
Oliver Hader commented on patch set 11 CR -1 03/11/20, 14:10
On it...PersistedAliasMapper.php:201Site-uniqueness is probably not required for unique records (fetched by `uid`) -
Oliver Hader uploaded patch set 12 03/11/20, 17:26
-
TYPO3com voted on patch set 12 V -1 03/11/20, 17:27 Completed build in 21s on Wed, 11 Mar, 05:27 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1261
-
Oliver Hader commented on patch set 12 03/11/20, 17:28
→ requires https://review.typo3.org/c/Packages/TYPO3.CMS/+/63644 (that's why Bamboo is failing) -
Oliver Hader uploaded patch set 13 03/11/20, 17:35
-
TYPO3com voted on patch set 13 V -1 03/11/20, 17:35 Completed build in 21s on Wed, 11 Mar, 05:35 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1262
-
Helmut Hummel commented on patch set 13 03/12/20, 15:31
> Patch Set 11: > > → https://review.typo3.org/c/Packages/TYPO3.CMS/+/63644 what do you think in general about having the possibility to resolve the parent Site from a SiteLanguage instance > > This way, we could avoid introducing new interfaces (since SiteLanguage needs to be given anyway) and would use Site & SiteLanguage "as a whole" structure... You mean besides introducing circular references and all downsides that come with these? If it is only to avoid the additional interface, I'd rather introduce the interface and make clear that this class also has Site as dependency instead of hiding this dependency in the SiteLanguage dependency. Are there other use cases for the back reference to Site in SiteLanguage?PersistedAliasMapper.php:201Reply UnresolvedYeah, you might be right here. Have to dig further when exactly this can be called. -
Oliver Hader commented on patch set 13 03/12/20, 15:52
> Patch Set 13: > > This way, we could avoid introducing new interfaces (since SiteLanguage needs to be given anyway) and would use Site & SiteLanguage "as a whole" structure... > > You mean besides introducing circular references and all downsides that come with these? Could you please be less polemic and a little bit more specific? Which downsides to you have in mind for the specific scenario of Site and SiteLanguage? > If it is only to avoid the additional interface, I'd rather introduce the interface and make clear that this class also has Site as dependency instead of hiding this dependency in the SiteLanguage dependency. It would be possible to inject instances that are not part of the same aggregate root, e.g. `{Site A, Language 'fr' of Site B}` - thus it has to be ensured the combination is valid. -
Oliver Hader commented on patch set 13 03/12/20, 16:23
I forgot to mention that adding a new mandatory argument to AspectFactory is potentially a breaking change in user-land code... Thus, at least there should be an Important.rst and extension scanner configuration. -
Oliver Hader uploaded patch set 14 03/12/20, 16:55
-
TYPO3com voted on patch set 14 V -1 03/12/20, 16:55 Completed build in 22s on Thu, 12 Mar, 04:55 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1292
-
Oliver Hader uploaded patch set 15 03/12/20, 16:56
-
TYPO3com voted on patch set 15 V -1 03/12/20, 17:08 Completed build in 11m 40s on Thu, 12 Mar, 05:08 PM Test Summary: 42 of 72736 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1293
-
Oliver Hader uploaded patch set 16 03/12/20, 17:13
-
TYPO3com voted on patch set 16 V -1 03/12/20, 17:24 Completed build in 10m 53s on Thu, 12 Mar, 05:24 PM Test Summary: 72242 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1294
-
TYPO3com voted on patch set 16 V +1 03/12/20, 19:36 Completed build in 2h 34m 22s on Thu, 12 Mar, 07:36 PM Test Summary: 72252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1294
-
Rémy DANIEL commented on patch set 16 CR -1 03/18/20, 13:26
PersistedAliasMapper.php:241UnresolvedBe careful, the array_filter in filterContainedInSite preserves keys. So the `return $results[0] ?? null;` will return null if case any of the first result if kept after filterContainedInSite. -
Oliver Hader uploaded patch set 17 03/19/20, 20:47
-
TYPO3com voted on patch set 17 V +1 03/19/20, 21:07 Completed build in 20m 26s on Thu, 19 Mar, 09:07 PM Test Summary: 72171 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1475
-
Rémy DANIEL commented on patch set 17 CR -1 03/20/20, 15:02
SiteAccessorTrait.php:70UnresolvedThis is the return of array_filter which needs to be passed through array_values, not the input arg. -
Oliver Hader commented on patch set 17 03/20/20, 15:59
@Rémy DANIEL: Do you mind fixing it yourself? https://docs.typo3.org/m/typo3/guide-contributionworkflow/master/en-us/BugfixingAZ/Index.html#quickstart-create-a-patch -
Oliver Hader marked it work in progress 03/20/20, 15:59
-
Oliver Hader commented on patch set 17 CR -1 03/24/20, 18:43
On it again... -
Oliver Hader uploaded patch set 18 03/24/20, 19:40
-
TYPO3com voted on patch set 18 V +1 03/24/20, 19:51 Completed build in 10m 34s on Tue, 24 Mar, 07:51 PM Test Summary: 73071 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1679
-
Oliver Hader uploaded patch set 19 03/24/20, 21:09
-
Oliver Hader commented on patch set 19 03/24/20, 21:09
This change is ready for review. -
TYPO3com voted on patch set 19 V +1 03/24/20, 21:29 Completed build in 16m 58s on Tue, 24 Mar, 09:29 PM Test Summary: 73224 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1686
-
Oliver Hader commented on patch set 19 03/28/20, 08:42
PING - are there any remarks on this change? Changes are higher to have it in next v9.5 release (in three days) when it's reviewed & tested... ;-) -
Oliver Hader voted on patch set 19 V +1 03/30/20, 15:05
-
Jonas Eberle commented on patch set 19 V +1 03/30/20, 21:26
Tested with 2 sites and news with identical slugs. Before: URL generated OK, but resolved to only news from 1 domain After: All OK -
Benni Mack voted on patch set 19 V +1 CR +1 03/31/20, 09:39
-
Oliver Hader voted on patch set 19 V +2 CR +2 04/02/20, 09:57
-
Oliver Hader merged patch set 20 04/02/20, 09:58
-
Andreas Kienast commented on patch set 20 04/04/20, 14:58
MethodArgumentRequiredMatcher.php:26The method name is missing here which breaks the extension scanner -
Andreas Kienast commented on patch set 20 04/04/20, 15:06
MethodArgumentRequiredMatcher.php:26Reply Unresolved
AspectFactory.php:113