Review main Merged

61590[FEATURE] PHP API for backend JavaScript notifications

Frank Nägler CR +2 V +2 Hard +475 −0 updated 09/24/19, 10:38

Commit message

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 6

Review log 3050

Show 1325 earlier messages
  1. Frank Nägler uploaded patch set 1 09/02/19, 14:36

  2. Frank Nägler marked it work in progress 09/02/19, 14:37

  3. TYPO3com voted on patch set 1 V -1 09/02/19, 14:46 Completed build in 09m 58s on Mon, 2 Sep, 02:46 PM Test Summary: 47180 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35995

  4. Frank Nägler uploaded patch set 2 09/02/19, 15:19

  5. TYPO3com voted on patch set 2 V +1 09/02/19, 15:29 Completed build in 10m 01s on Mon, 2 Sep, 03:29 PM Test Summary: 47252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-35996

  6. Frank Nägler uploaded patch set 3 09/03/19, 07:19

  7. TYPO3com voted on patch set 3 V +1 09/03/19, 07:31 Completed build in 11m 58s on Tue, 3 Sep, 07:31 AM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36008

  8. Frank Nägler uploaded patch set 4 09/03/19, 07:34

  9. TYPO3com voted on patch set 4 V +1 09/03/19, 07:45 Completed build in 10m 56s on Tue, 3 Sep, 07:45 AM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36009

  10. Frank Nägler uploaded patch set 5 09/03/19, 09:06

  11. Frank Nägler updated the commit message in patch set 6 09/03/19, 09:11

  12. Frank Nägler uploaded patch set 7 09/03/19, 09:13

  13. Georg Ringer commented on patch set 7 09/03/19, 09:16

    Action.php:2 Unresolved

    declare_strict

    NotificationService.php:1 Unresolved

    declare_strict
  14. TYPO3com voted on patch set 5 V +1 09/03/19, 09:17 Completed build in 11m 14s on Tue, 3 Sep, 09:17 AM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36012

  15. TYPO3com voted on patch set 6 V -1 09/03/19, 09:23 Completed build in 11m 30s on Tue, 3 Sep, 09:23 AM Test Summary: 46968 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36013

  16. TYPO3com voted on patch set 7 V -1 09/03/19, 09:25 Completed build in 11m 01s on Tue, 3 Sep, 09:25 AM Test Summary: 1 of 47617 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36014

  17. TYPO3com voted on patch set 7 V +1 09/03/19, 09:59 Completed build in 56m 18s on Tue, 3 Sep, 09:59 AM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36014

  18. Frank Nägler uploaded patch set 8 09/03/19, 10:45

  19. TYPO3com voted on patch set 8 V -1 09/03/19, 10:46 Completed build in 17s on Tue, 3 Sep, 10:46 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36017

  20. Frank Nägler uploaded patch set 9 09/03/19, 10:47

  21. TYPO3com voted on patch set 9 V -1 09/03/19, 10:58 Completed build in 10m 51s on Tue, 3 Sep, 10:58 AM Test Summary: 47031 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36018

  22. TYPO3com voted on patch set 9 V +1 09/03/19, 11:12 Completed build in 36m 33s on Tue, 3 Sep, 11:12 AM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36018

  23. Frank Nägler uploaded patch set 10 09/04/19, 10:30

  24. Frank Nägler uploaded patch set 11 09/04/19, 10:42

  25. TYPO3com voted on patch set 10 V -1 09/04/19, 10:42 Completed build in 12m 06s on Wed, 4 Sep, 10:42 AM Test Summary: 1 of 47613 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36048

  1. Andreas Kienast uploaded patch set 12 09/04/19, 10:48

  2. Andreas Kienast uploaded patch set 13 09/04/19, 10:49

  3. Frank Nägler commented on patch set 13 09/04/19, 10:49

    This change is ready for review.
  4. TYPO3com voted on patch set 11 V -1 09/04/19, 10:55 Completed build in 12m 50s on Wed, 4 Sep, 10:55 AM Test Summary: 47008 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36050

  5. TYPO3com voted on patch set 12 V +1 09/04/19, 10:59 Completed build in 11m 06s on Wed, 4 Sep, 10:59 AM Test Summary: 47254 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36051

  6. TYPO3com voted on patch set 13 V +1 09/04/19, 11:02 Completed build in 11m 44s on Wed, 4 Sep, 11:02 AM Test Summary: 47253 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36052

  7. Andreas Kienast voted on patch set 13 V +1 CR +1 09/04/19, 11:25

  8. Susi Moog commented on patch set 13 CR -1 09/04/19, 11:42

    missing tests
  9. Frank Nägler uploaded patch set 14 09/04/19, 12:19

  10. TYPO3com voted on patch set 14 V -1 09/04/19, 12:20 Completed build in 16s on Wed, 4 Sep, 12:20 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36055

  11. Susi Moog uploaded patch set 15 09/04/19, 12:36

  12. TYPO3com voted on patch set 15 V -1 09/04/19, 12:37 Completed build in 11s on Wed, 4 Sep, 12:37 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36056

  13. Susi Moog uploaded patch set 16 09/04/19, 12:49

  14. TYPO3com voted on patch set 16 V -1 09/04/19, 12:49 Completed build in 12s on Wed, 4 Sep, 12:49 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36057

  15. Frank Nägler uploaded patch set 17 09/04/19, 13:05

  16. Frank Nägler uploaded patch set 18 09/04/19, 13:07

  17. TYPO3com voted on patch set 17 V -1 09/04/19, 13:17 Completed build in 11m 49s on Wed, 4 Sep, 01:17 PM Test Summary: 1 of 47716 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36059

  18. TYPO3com voted on patch set 18 V +1 09/04/19, 13:20 Completed build in 11m 50s on Wed, 4 Sep, 01:20 PM Test Summary: 47357 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36060

  19. Andreas Kienast voted on patch set 18 V +1 CR +1 09/04/19, 13:36

  20. Susi Moog voted on patch set 18 V +2 CR +2 09/04/19, 13:42

  21. Susi Moog merged patch set 19 09/04/19, 13:42

  22. Oliver Hader commented on patch set 19 09/17/19, 16:44

    Besides getting farther away from content security policies, I see a rising cross-site scripting star here...
  23. Andreas Kienast commented on patch set 19 09/18/19, 06:46

    > Patch Set 19: > > Besides getting farther away from content security policies, I see a rising cross-site scripting star here... I agree on the CSP part, but we needed a way to trigger JS notifications via PHP. IMO this can be solved only once we have WebSockets, XHR Long Polling of whatever in place. But I fail to see XSS here, can you please elaborate?
  24. Frank Nägler commented on patch set 19 09/18/19, 06:48

    > Besides getting farther away from content security policies, I see a rising cross-site scripting star here... regarding CSP I agree, but at the moment I see no other possible solution to render a notification from PHP side. And I see no concrete XSS issue here. As mentioned in the other patch I would prefer that we talk about the issues you see.
  25. Andreas Kienast wrote 09/24/19, 10:38

    Created a revert of this change as I8cd69cb9238b187ed6d6343548adf03a4c2bb464