Review main Merged

61591[TASK] Make "Check TCA in ext_tables.php" install tool wizard more helpful

Tymoteusz Motylewski CR +2 V +2 Easy +19 −4 updated 09/05/19, 10:55

Commit message

Add information about how user can fix the issue.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Benjamin Franzke +1
    • Oli Bartsch +1
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 1220

  1. Tymoteusz Motylewski uploaded patch set 1 09/02/19, 20:07

  2. TYPO3com voted on patch set 1 V +1 09/02/19, 20:16 Completed build in 09m 11s on Mon, 2 Sep, 08:16 PM Test Summary: 47252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36001

  3. Markus Klein commented on patch set 1 09/02/19, 20:23

    TcaExtTablesCheck.ts:55

    look
  4. Tymoteusz Motylewski uploaded patch set 2 09/02/19, 20:48

  5. Tymoteusz Motylewski commented on patch set 2 09/02/19, 20:49

    TcaExtTablesCheck.ts:55 Reply

    Done
  6. TYPO3com voted on patch set 2 V -1 09/02/19, 21:02 Completed build in 13m 13s on Mon, 2 Sep, 09:02 PM Test Summary: 1 of 47617 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36004

  7. TYPO3com voted on patch set 2 V +1 09/02/19, 21:04 Completed build in 28m 09s on Mon, 2 Sep, 09:04 PM Test Summary: 47258 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36004

  8. Andreas Kienast uploaded patch set 3 09/04/19, 11:57

  9. Andreas Kienast voted on patch set 3 CR +1 09/04/19, 12:02

  10. TYPO3com voted on patch set 3 V -1 09/04/19, 12:08 Completed build in 10m 40s on Wed, 4 Sep, 12:08 PM Test Summary: 47243 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36053

  11. TYPO3com voted on patch set 3 V +1 09/04/19, 12:22 Completed build in 36m 01s on Wed, 4 Sep, 12:22 PM Test Summary: 47252 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36053

  12. Oli Bartsch commented on patch set 3 09/04/19, 13:39

    TcaExtTablesCheck.ts:55 Unresolved

    Should we change that to single quotes?
  13. Susi Moog voted on patch set 3 CR +1 09/05/19, 06:30

  14. Benjamin Franzke uploaded patch set 4 09/05/19, 07:03

  15. TYPO3com voted on patch set 4 V -1 09/05/19, 07:26 Completed build in 20m 39s on Thu, 5 Sep, 07:26 AM Test Summary: 1 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36077

  16. TYPO3com voted on patch set 4 V +1 09/05/19, 07:30 Completed build in 45m 19s on Thu, 5 Sep, 07:30 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36077

  17. TYPO3com commented on patch set 4 09/05/19, 07:36 Completed build in 14m 33s on Thu, 5 Sep, 07:36 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36079

  18. Oli Bartsch voted on patch set 4 V +1 CR +1 09/05/19, 07:52

  19. Richard Haeser voted on patch set 4 V +2 CR +2 09/05/19, 10:55

  20. Richard Haeser merged patch set 5 09/05/19, 10:55