Review 9.5 Merged

61594[BUGFIX] Set rel="noopener noreferrer" for external links

Frank Nägler CR +2 V +2 Normal +33 −33 updated 08/30/19, 07:49

Commit message

This patch adds rel="noopener noreferrer" for external links in
backend and install tool for security reasons.
If this is not set, the other page can access the window object
with the window.opener property.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 1

Files 16

Review log 57

  1. Frank Nägler commented on patch set 1 08/30/19, 06:53

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/about/Resources/Private/Partials/Donation.html * typo3/sysext/backend/Resources/Private/Layouts/Login.html * typo3/sysext/core/Resources/Private/Templates/ErrorPage/Error.html * typo3/sysext/extensionmanager/Resources/Private/Templates/List/ShowAllVersions.html * typo3/sysext/install/Resources/Private/Templates/Maintenance/Cards.html * typo3/sysext/install/Resources/Private/Templates/Upgrade/Cards.html * typo3/sysext/install/Resources/Private/Templates/Upgrade/ExtensionScanner.html * typo3/sysext/linkvalidator/Resources/Private/Templates/mod_template.html * typo3/sysext/workspaces/Resources/Private/Templates/Preview/Index.html
  2. Frank Nägler uploaded patch set 2 08/30/19, 07:02

  3. Frank Nägler commented on patch set 2 08/30/19, 07:03

    This change is ready for review.
  4. TYPO3com voted on patch set 1 V -1 08/30/19, 07:05 Completed build in 11m 26s on Fri, 30 Aug, 07:05 AM Test Summary: 67 of 51050 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1077

  5. TYPO3com voted on patch set 2 V +1 08/30/19, 07:23 Completed build in 21m 00s on Fri, 30 Aug, 07:23 AM Test Summary: 50582 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1078

  6. Andreas Kienast voted on patch set 2 V +2 CR +2 08/30/19, 07:49

  7. Andreas Kienast merged patch set 3 08/30/19, 07:49