Review 9.5 Merged

61599[BUGFIX] Respect readOnly for inline relation

Richard Haeser CR +2 V +2 Easy +20 −5 updated 09/05/19, 11:51

Commit message

If a TCA field is set to readOnly=true and is using the type "inline",
all buttons are now hidden and the fields of the relation are set to
readOnly as well.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 57

  1. Richard Haeser commented on patch set 1 09/05/19, 11:12

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Classes/Form/Container/InlineControlContainer.php
  2. TYPO3com voted on patch set 1 V -1 09/05/19, 11:13 Completed build in 12s on Thu, 5 Sep, 11:13 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1105

  3. Richard Haeser uploaded patch set 2 09/05/19, 11:34

  4. Richard Haeser commented on patch set 2 09/05/19, 11:34

    This change is ready for review.
  5. TYPO3com voted on patch set 2 V +1 09/05/19, 11:46 Completed build in 11m 56s on Thu, 5 Sep, 11:46 AM Test Summary: 50604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1106

  6. Richard Haeser voted on patch set 2 V +2 CR +2 09/05/19, 11:51

  7. Richard Haeser merged patch set 3 09/05/19, 11:51