Review 9.5 Merged

61600[BUGFIX] Name test class after subject under test

Richard Haeser CR +2 V +2 Easy +2 −2 updated 09/05/19, 17:49

Commit message

The subject under test is SiteConfigurationDataGroup::class,
due to the wrong name IDEs will not connect the test class with it.
To resolve the confusion, the test class gets named after the
class it tests.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Oliver Klee +1
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 69

  1. Richard Haeser commented on patch set 1 09/05/19, 17:16

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/backend/Tests/Unit/Form/FormDataGroup/SiteConfigurationTest.php
  2. TYPO3com voted on patch set 1 V -1 09/05/19, 17:17 Completed build in 14s on Thu, 5 Sep, 05:17 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1108

  3. Richard Haeser uploaded patch set 2 09/05/19, 17:22

  4. Richard Haeser commented on patch set 2 09/05/19, 17:22

    This change is ready for review.
  5. Oliver Klee voted on patch set 2 CR +1 09/05/19, 17:23

  6. TYPO3com voted on patch set 2 V -1 09/05/19, 17:35 Completed build in 12m 23s on Thu, 5 Sep, 05:35 PM Test Summary: 50292 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1109

  7. TYPO3com voted on patch set 2 V +1 09/05/19, 17:48 Completed build in 12m 39s on Thu, 5 Sep, 05:48 PM Test Summary: 50604 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1110

  8. Richard Haeser voted on patch set 2 V +2 CR +2 09/05/19, 17:49

  9. Richard Haeser merged patch set 3 09/05/19, 17:49