Review 9.5 Merged

61603[BUGFIX] Allow selective saving in SiteConfiguration

Richard Haeser CR +2 V +2 Hard +365 −15 updated 09/10/19, 13:56

Commit message

YAML SiteConfiguration allows imports and custom configuration
that is not configurable via UI to be written directly into the
configuration files, however, when saving with the UI these
settings are overwritten and resolved. This change changes the
SiteConfiguration in a way, that only modified values are written
and imports are completely left as they are.

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
  • Verified V +2 Done
    • Andreas Kienast +2
    • TYPO3com +1 CI

Issues 2

Files 8

Review log 811

  1. Richard Haeser commented on patch set 1 09/07/19, 11:23

    Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php
  2. TYPO3com voted on patch set 1 V -1 09/07/19, 11:24 Completed build in 25s on Sat, 7 Sep, 11:24 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1118

  3. Susi Moog uploaded patch set 2 09/09/19, 07:14

  4. Susi Moog commented on patch set 2 09/09/19, 07:15

    resolved conflict in test.
  5. TYPO3com voted on patch set 2 V +1 09/09/19, 07:26 Completed build in 12m 08s on Mon, 9 Sep, 07:26 AM Test Summary: 50616 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1119

  6. Andreas Kienast commented on patch set 2 CR -2 09/09/19, 08:15

    It seems we have a nasty edge-case that breaks the configuration. Blocked until we figured it out.
  7. Andreas Kienast uploaded patch set 3 09/10/19, 08:14

  8. Andreas Kienast voted on patch set 3 CR 0 09/10/19, 08:15

  9. TYPO3com voted on patch set 3 V +1 09/10/19, 08:26 Completed build in 11m 54s on Tue, 10 Sep, 08:26 AM Test Summary: 50620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1132

  10. Andreas Kienast voted on patch set 3 V +2 CR +2 09/10/19, 13:56

  11. Andreas Kienast merged patch set 4 09/10/19, 13:56