61603[BUGFIX] Allow selective saving in SiteConfiguration
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
-
Verified V +2 Done
- Andreas Kienast +2
- TYPO3com +1 CI
Issues 2
Files 8
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+73 −4
- typo3/sysext/core/Tests/Functional/SiteHandling/SiteBasedTestTrait.php+3 −1
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config1.yamlnew+48 −0
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config1_expected.yamlnew+35 −0
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2.yamlnew+35 −0
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2_expected.yamlnew+47 −0
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/include.yamlnew+5 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+119 −10
Review log 811
-
Richard Haeser commented on patch set 1 09/07/19, 11:23
Cherry Picked from branch master. The following files contain Git conflicts: * typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php -
TYPO3com voted on patch set 1 V -1 09/07/19, 11:24 Completed build in 25s on Sat, 7 Sep, 11:24 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1118
-
Susi Moog uploaded patch set 2 09/09/19, 07:14
-
Susi Moog commented on patch set 2 09/09/19, 07:15
resolved conflict in test. -
TYPO3com voted on patch set 2 V +1 09/09/19, 07:26 Completed build in 12m 08s on Mon, 9 Sep, 07:26 AM Test Summary: 50616 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1119
-
Andreas Kienast commented on patch set 2 CR -2 09/09/19, 08:15
It seems we have a nasty edge-case that breaks the configuration. Blocked until we figured it out. -
Andreas Kienast uploaded patch set 3 09/10/19, 08:14
-
Andreas Kienast voted on patch set 3 CR 0 09/10/19, 08:15
-
TYPO3com voted on patch set 3 V +1 09/10/19, 08:26 Completed build in 11m 54s on Tue, 10 Sep, 08:26 AM Test Summary: 50620 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1132
-
Andreas Kienast voted on patch set 3 V +2 CR +2 09/10/19, 13:56
-
Andreas Kienast merged patch set 4 09/10/19, 13:56