Review 9.5 Merged

61612[BUGFIX] Strip logical operator prefix in config.additionalWhere

Tymoteusz Motylewski CR +2 V +2 Normal +104 −4 updated 09/03/19, 19:48

Commit message

When building the additionalWhere clause in the
RecordsXmlSitemapDataProvider, a possible `AND` operator
must be removed. Doctrine's queryBuilder adds this prefix
automatically.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
  • Verified V +2 Done
    • Richard Haeser +2
    • TYPO3com +1 CI

Issues 1

Files 3

Review log 611

  1. Tymoteusz Motylewski uploaded patch set 1 09/02/19, 20:42

  2. TYPO3com voted on patch set 1 V -1 09/02/19, 20:55 Completed build in 12m 24s on Mon, 2 Sep, 08:55 PM Test Summary: 3 of 50747 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1091

  3. Richard Haeser commented on patch set 1 09/02/19, 21:41

    On it
  4. Richard Haeser rebased onto patch set 2 09/03/19, 18:55

  5. TYPO3com voted on patch set 2 V -1 09/03/19, 19:07 Completed build in 12m 18s on Tue, 3 Sep, 07:07 PM Test Summary: 3 of 50747 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1094

  6. Richard Haeser uploaded patch set 3 09/03/19, 19:09

  7. TYPO3com voted on patch set 3 V -1 09/03/19, 19:21 Completed build in 12m 34s on Tue, 3 Sep, 07:21 PM Test Summary: 50276 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1095

  8. TYPO3com commented on patch set 3 09/03/19, 19:34 Completed build in 12m 23s on Tue, 3 Sep, 07:34 PM Test Summary: 50163 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1096

  9. TYPO3com voted on patch set 3 V +1 09/03/19, 19:46 Completed build in 12m 02s on Tue, 3 Sep, 07:46 PM Test Summary: 50588 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1097

  10. Richard Haeser voted on patch set 3 V +2 CR +2 09/03/19, 19:47

  11. Richard Haeser merged patch set 4 09/03/19, 19:48