61615[BUGFIX] Don't include path for fragment-only links
Commit message
Review
-
Code review CR +2 Done
- Daniel Goerz +2
- Susi Moog +1
-
Verified V +2 Done
- Daniel Goerz +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 1319
-
Andreas Wolf uploaded patch set 1 09/03/19, 14:21
-
TYPO3com voted on patch set 1 V -1 09/03/19, 14:21 Completed build in 12s on Tue, 3 Sep, 02:21 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36025
-
Oliver Klee commented on patch set 1 09/03/19, 15:34
Can we cover this change with tests? -
Andreas Wolf uploaded patch set 2 09/03/19, 15:43
-
TYPO3com voted on patch set 2 V -1 09/03/19, 15:52 Completed build in 09m 06s on Tue, 3 Sep, 03:52 PM Test Summary: 46991 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36026
-
Markus Klein commented on patch set 2 09/03/19, 16:45
I think we should add a test for that. \TYPO3\CMS\Frontend\Tests\Functional\ContentObject\ContentObjectRendererTest::typolinkReturnsCorrectLinkForSectionToHomePageWithUrlRewriting something like this?PageLinkBuilder.php:384UnresolvedI prefer the operator-syntax: !$useAbsoluteUrlPageLinkBuilder.php:390indentation wrong -
Andreas Kienast commented on patch set 2 09/04/19, 11:55
PageLinkBuilder.php:390ReplyCGL check is fine about this -
Markus Klein commented on patch set 2 09/04/19, 18:04
PageLinkBuilder.php:390Reply UnresolvedInteresting... but okay, non of my business -
TYPO3com commented on patch set 2 01/19/20, 11:28 Completed build in 12m 19s on Sun, 19 Jan, 11:28 AM Test Summary: 70433 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40081
-
TYPO3com voted on patch set 2 V +1 01/19/20, 11:34 Completed build in 31m 13s on Sun, 19 Jan, 11:34 AM Test Summary: 70442 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40081
-
Susi Moog rebased onto patch set 3 03/26/20, 17:55
-
TYPO3com voted on patch set 3 V -1 03/26/20, 18:06 Completed build in 10m 48s on Thu, 26 Mar, 06:06 PM Test Summary: 72702 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1784
-
TYPO3com voted on patch set 3 V +1 03/26/20, 18:11 Completed build in 26m 17s on Thu, 26 Mar, 06:11 PM Test Summary: 73014 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-1784
-
Susi Moog commented on patch set 3 03/27/20, 14:32
PageLinkBuilder.php:401is this set in case of USER_INT plugins / with cached TSFE? -
Benni Mack commented on patch set 3 03/27/20, 14:59
PageLinkBuilder.php:401Reply Unresolvedyes -
Susi Moog voted on patch set 3 V +1 CR +1 03/27/20, 15:00
-
Daniel Goerz voted on patch set 3 V +2 CR +2 03/27/20, 15:01
-
Daniel Goerz merged patch set 4 03/27/20, 15:01
-
Oliver Hader commented on patch set 4 12/23/21, 14:16
PageLinkBuilder.php:400UnresolvedShouldn't `empty($conf['addQueryString'])` have been enough here?