61625[BUGFIX] Hash extension versions into requireJS bust parameter
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Frank Nägler +1
-
Verified V +2 Done
- Andreas Kienast +2
- Frank Nägler +1
- TYPO3com +1 CI
Issues 1
Files 1
Review log 912
-
Benjamin Franzke uploaded patch set 1 09/05/19, 06:45
-
Andreas Kienast commented on patch set 1 09/05/19, 07:03
-
Benjamin Franzke commented on patch set 1 09/05/19, 07:09
PageRenderer.php:1352ReplyNo, wouldn't. I wasn't sure whether the hmac calculation would become less efficient, as it would need to handle a longer string – but I didn't measure that and the result is cached, so it would actually be fine. One "slight" drawback: (De)Activating a core extension would trigger a new bust parameter (although not needed as the core versions are synchronous), while the current solution using TYPO3_version and type != 'typo3-cms-framework' would not. Anyway, for the sake of clean code I'd be fine with dropping TYPO3_version anyway. -
TYPO3com voted on patch set 1 V +1 09/05/19, 07:20 Completed build in 28m 59s on Thu, 5 Sep, 07:20 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36076
-
Benjamin Franzke uploaded patch set 2 09/05/19, 07:25
-
Benjamin Franzke commented on patch set 2 09/05/19, 07:26
PageRenderer.php:1352ReplyAdapted in patchset 2. -
TYPO3com voted on patch set 2 V -1 09/05/19, 07:41 Completed build in 13m 39s on Thu, 5 Sep, 07:41 AM Test Summary: 1 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36080
-
TYPO3com voted on patch set 2 V +1 09/05/19, 08:04 Completed build in 18m 33s on Thu, 5 Sep, 08:04 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36082
-
Andreas Kienast voted on patch set 2 CR +1 09/05/19, 10:32
-
Frank Nägler voted on patch set 2 V +1 CR +1 09/06/19, 11:32
-
Andreas Kienast voted on patch set 2 V +2 CR +2 09/06/19, 11:41
-
Andreas Kienast merged patch set 3 09/06/19, 11:41
PageRenderer.php:1352