Review main Merged

61628[BUGFIX] Name test class after subject under test

Anja Leichsenring CR +2 V +2 Easy +1 −1 updated 09/05/19, 10:51

Commit message

The subject under test is SiteConfigurationDataGroup::class,
due to the wrong name IDEs will not connect the test class with it.
To resolve the confusion, the test class gets named after the
class it tests.

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 45

  1. Anja Leichsenring uploaded patch set 1 09/05/19, 10:19

  2. TYPO3com voted on patch set 1 V +1 09/05/19, 10:29 Completed build in 10m 21s on Thu, 5 Sep, 10:29 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36087

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/05/19, 10:31

  4. Richard Haeser voted on patch set 1 V +2 CR +2 09/05/19, 10:51

  5. Richard Haeser merged patch set 2 09/05/19, 10:51