Review main Merged

61629[TASK] Add UnitTests for SiteConfiguration

Anja Leichsenring CR +2 V +2 Normal +83 −0 updated 09/06/19, 08:43

Commit message

Review

  • Code review CR +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Richard Haeser +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 812

  1. Anja Leichsenring uploaded patch set 1 09/05/19, 11:03

  2. TYPO3com voted on patch set 1 V -1 09/05/19, 11:04 Completed build in 11s on Thu, 5 Sep, 11:04 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36090

  3. Anja Leichsenring uploaded patch set 2 09/05/19, 11:04

  4. TYPO3com voted on patch set 2 V +1 09/05/19, 11:13 Completed build in 08m 49s on Thu, 5 Sep, 11:13 AM Test Summary: 47369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36091

  5. Oliver Klee commented on patch set 2 09/05/19, 11:22

    SiteConfigurationTest.php:2 Unresolved

    Can we have this strict, please?

    SiteConfigurationTest.php:3 Unresolved

    Shouldn't the namespace have "Tests" in it?

    SiteConfigurationTest.php:45 Unresolved

    : void for both tests
  6. Anja Leichsenring uploaded patch set 3 09/05/19, 16:31

  7. TYPO3com voted on patch set 3 V +1 09/05/19, 16:44 Completed build in 12m 39s on Thu, 5 Sep, 04:44 PM Test Summary: 47369 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36110

  8. Andreas Kienast uploaded patch set 4 09/06/19, 07:52

  9. TYPO3com voted on patch set 4 V +1 09/06/19, 08:04 Completed build in 11m 45s on Fri, 6 Sep, 08:04 AM Test Summary: 47368 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36118

  10. Andreas Kienast voted on patch set 4 V +1 CR +1 09/06/19, 08:36

  11. Richard Haeser voted on patch set 4 V +2 CR +2 09/06/19, 08:43

  12. Richard Haeser merged patch set 5 09/06/19, 08:43