61630[FEATURE] Add dependency injection support for console commands
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Achim Fritz +1
-
Verified V +2 Done
- Benni Mack +2
- Achim Fritz +1
- TYPO3com +1 CI
Issues 1
Files 29
- typo3/sysext/backend/Configuration/Commands.phpdeleted+0 −20
- typo3/sysext/backend/Configuration/Services.yaml+12 −0
- typo3/sysext/core/Classes/Command/SiteListCommand.php+12 −2
- typo3/sysext/core/Classes/Console/CommandApplication.php+11 −4
- typo3/sysext/core/Classes/Console/CommandRegistry.php6+129 −6
- typo3/sysext/core/Classes/DependencyInjection/ConsoleCommandPass.phpnew+67 −0
- typo3/sysext/core/Classes/ServiceProvider.php+10 −1
- typo3/sysext/core/Configuration/Commands.phpdeleted+0 −23
- typo3/sysext/core/Configuration/Services.php+1 −0
- typo3/sysext/core/Configuration/Services.yaml+42 −0
- typo3/sysext/core/Documentation/Changelog/master/Deprecation-89139-ConsoleCommandsConfigurationMigratedToSymfonyServiceTags.rstnew+73 −0
- typo3/sysext/core/Documentation/Changelog/master/Feature-89139-AddDependencyInjectionSupportForConsoleCommands.rstnew+73 −0
- typo3/sysext/core/Tests/Unit/Console/CommandRegistryTest.php+71 −87
- typo3/sysext/core/Tests/UnitDeprecated/Console/CommandRegistryTest.phpnew+181 −0
- typo3/sysext/extensionmanager/Configuration/Commands.phpdeleted+0 −17
- typo3/sysext/extensionmanager/Configuration/Services.yaml+28 −0
- typo3/sysext/impexp/Configuration/Commands.phpdeleted+0 −12
- typo3/sysext/impexp/Configuration/Services.yaml+5 −0
- typo3/sysext/install/Classes/ServiceProvider.php+34 −0
- typo3/sysext/install/Configuration/ExtensionScanner/Php/MethodCallMatcher.php+8 −0
Show 9 more files
- typo3/sysext/install/Configuration/Commands.phpdeleted+0 −20
- typo3/sysext/lowlevel/Configuration/Commands.phpdeleted+0 −33
- typo3/sysext/lowlevel/Configuration/Services.yaml+40 −0
- typo3/sysext/redirects/Configuration/Commands.phpdeleted+0 −13
- typo3/sysext/redirects/Configuration/Services.yaml+5 −0
- typo3/sysext/scheduler/Configuration/Commands.phpdeleted+0 −14
- typo3/sysext/scheduler/Configuration/Services.yaml+6 −0
- typo3/sysext/workspaces/Configuration/Commands.phpdeleted+0 −18
- typo3/sysext/workspaces/Configuration/Services.yaml+15 −0
Review log 2752
Show 1327 earlier messages
-
Benjamin Franzke uploaded patch set 1 09/05/19, 11:48
-
Benjamin Franzke marked it work in progress 09/05/19, 11:48
-
TYPO3com voted on patch set 1 V -1 09/05/19, 11:58 Completed build in 10m 29s on Thu, 5 Sep, 11:58 AM Test Summary: 16 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36093
-
Benjamin Franzke uploaded patch set 2 09/05/19, 12:24
-
Benjamin Franzke uploaded patch set 3 09/05/19, 12:27
-
Benjamin Franzke wrote 09/05/19, 12:28
Topic set to di -
TYPO3com voted on patch set 2 V -1 09/05/19, 12:37 Completed build in 12m 34s on Thu, 5 Sep, 12:37 PM Test Summary: 17 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36095
-
TYPO3com voted on patch set 3 V +1 09/05/19, 12:43 Completed build in 12m 24s on Thu, 5 Sep, 12:43 PM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36097
-
Benjamin Franzke uploaded patch set 4 09/05/19, 12:55
-
TYPO3com voted on patch set 4 V -1 09/05/19, 13:08 Completed build in 12m 14s on Thu, 5 Sep, 01:08 PM Test Summary: 4 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36101
-
Benjamin Franzke uploaded patch set 5 09/05/19, 14:29
-
TYPO3com voted on patch set 5 V +1 09/05/19, 14:40 Completed build in 10m 48s on Thu, 5 Sep, 02:40 PM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36103
-
Benjamin Franzke uploaded patch set 6 09/06/19, 11:58
-
TYPO3com voted on patch set 6 V -1 09/06/19, 11:58 Completed build in 16s on Fri, 6 Sep, 11:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36136
-
Benjamin Franzke uploaded patch set 7 09/06/19, 12:01
-
TYPO3com voted on patch set 7 V -1 09/06/19, 12:12 Completed build in 10m 47s on Fri, 6 Sep, 12:12 PM Test Summary: 1 of 47728 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36137
-
TYPO3com commented on patch set 7 09/06/19, 12:31 Completed build in 11m 00s on Fri, 6 Sep, 12:31 PM Test Summary: 47081 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36140
-
TYPO3com commented on patch set 7 09/06/19, 18:28 Completed build in 09m 10s on Fri, 6 Sep, 06:28 PM Test Summary: 47131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36153
-
TYPO3com voted on patch set 7 V +1 09/06/19, 18:40 Completed build in 09m 50s on Fri, 6 Sep, 06:40 PM Test Summary: 47378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36154
-
Benjamin Franzke uploaded patch set 8 09/08/19, 13:58
-
TYPO3com voted on patch set 8 V +1 09/08/19, 14:08 Completed build in 09m 33s on Sun, 8 Sep, 02:08 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36188
-
Benjamin Franzke uploaded patch set 9 09/08/19, 18:50
-
TYPO3com voted on patch set 9 V -1 09/08/19, 19:01 Completed build in 10m 20s on Sun, 8 Sep, 07:01 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36192
-
Benjamin Franzke uploaded patch set 10 09/08/19, 19:04
-
TYPO3com voted on patch set 10 V -1 09/08/19, 19:14 Completed build in 09m 37s on Sun, 8 Sep, 07:14 PM Test Summary: 12 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36193
-
Benjamin Franzke uploaded patch set 11 09/08/19, 20:46
-
TYPO3com voted on patch set 11 V +1 09/08/19, 20:55 Completed build in 09m 02s on Sun, 8 Sep, 08:55 PM Test Summary: 47388 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36196
-
Benjamin Franzke uploaded patch set 12 09/11/19, 04:30
-
TYPO3com voted on patch set 12 V +1 09/11/19, 04:43 Completed build in 09m 56s on Wed, 11 Sep, 04:43 AM Test Summary: 47468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36271
-
Benjamin Franzke uploaded patch set 13 09/11/19, 06:17
-
TYPO3com voted on patch set 13 V -1 09/11/19, 06:38 Completed build in 12m 44s on Wed, 11 Sep, 06:38 AM Test Summary: 1 of 47827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36278
-
TYPO3com voted on patch set 13 V +1 09/11/19, 06:45 Completed build in 32m 49s on Wed, 11 Sep, 06:45 AM Test Summary: 47468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36278
-
Benjamin Franzke uploaded patch set 14 12/06/19, 08:00
Rebase -
TYPO3com voted on patch set 14 V +1 12/06/19, 08:12 Completed build in 10m 34s on Fri, 6 Dec, 08:12 AM Test Summary: 68778 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39126
-
Alexander Schnitzler commented on patch set 14 12/06/19, 09:25
I don't understand how this is supposed to work exactly. After I cherry-pick this change and update the container I only have 3 commands left. Those three that are configured for the FailsafeContainer, all others that are configured via Services.yaml don't show when I run bin/typo3. I am puzzled.CommandRegistry.php:202I don't understand this sentence.CommandRegistry.php:221compatbility is missing an "i"CommandRegistry.php:222dropped -> triggered (maybe) -
Benni Mack uploaded patch set 15 12/16/19, 15:06
-
Benni Mack uploaded patch set 16 12/16/19, 15:07
-
TYPO3com voted on patch set 15 V +1 12/16/19, 15:16 Completed build in 09m 41s on Mon, 16 Dec, 03:16 PM Test Summary: 68789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39460
-
TYPO3com voted on patch set 16 V +1 12/16/19, 15:19 Completed build in 09m 09s on Mon, 16 Dec, 03:19 PM Test Summary: 68789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39461
-
Benni Mack uploaded patch set 17 01/29/20, 10:18
-
TYPO3com voted on patch set 17 V -1 01/29/20, 10:30 Completed build in 12m 01s on Wed, 29 Jan, 10:30 AM Test Summary: 60786 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40311
-
TYPO3com voted on patch set 17 V +1 01/30/20, 09:07 Completed build in 23h 01m 05s on Thu, 30 Jan, 09:07 AM Test Summary: 70843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40311
-
Benjamin Franzke uploaded patch set 18 01/30/20, 21:20
-
TYPO3com voted on patch set 18 V +1 01/30/20, 21:35 Completed build in 14m 11s on Thu, 30 Jan, 09:35 PM Test Summary: 70855 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40375
-
Benni Mack uploaded patch set 19 02/14/20, 13:43
-
TYPO3com voted on patch set 19 V +1 02/14/20, 13:56 Completed build in 13m 11s on Fri, 14 Feb, 01:56 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-76
-
Benjamin Franzke updated the commit message in patch set 20 02/14/20, 13:58
-
Benjamin Franzke commented on patch set 20 02/14/20, 13:59
CommandRegistry.php:202ReplyDoneCommandRegistry.php:221ReplyAckCommandRegistry.php:222ReplyAck. -
TYPO3com voted on patch set 20 V +1 02/14/20, 14:11 Completed build in 13m 20s on Fri, 14 Feb, 02:11 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-77
-
Achim Fritz voted on patch set 20 V +1 CR +1 02/14/20, 18:36
-
Benni Mack commented on patch set 20 V +2 CR +2 02/14/20, 19:07
Alex. The latest patch works as expected for me. I will merge it now, but if you experience any issues after this patch let me know. -
Benni Mack merged patch set 21 02/14/20, 19:07