Review main Merged

61630[FEATURE] Add dependency injection support for console commands

Benjamin Franzke CR +2 V +2 Expert +823 −270 updated 02/14/20, 19:07

Commit message

Transform CommandRegistry into a symfony CommandLoader which
allows console commands to be created on demand.
That means commands are lazy loaded in order to avoid creating
all commands with all their dependencies in every console
invocation. Command will now be loaded when they are either
executed or when command metadata is required (e.g. for
the command listing)

The `site:list` command is adapted to make use of dependency injection.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Achim Fritz +1
  • Verified V +2 Done
    • Benni Mack +2
    • Achim Fritz +1
    • TYPO3com +1 CI

Issues 1

Files 29

Show 9 more files

Review log 2752

Show 1327 earlier messages
  1. Benjamin Franzke uploaded patch set 1 09/05/19, 11:48

  2. Benjamin Franzke marked it work in progress 09/05/19, 11:48

  3. TYPO3com voted on patch set 1 V -1 09/05/19, 11:58 Completed build in 10m 29s on Thu, 5 Sep, 11:58 AM Test Summary: 16 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36093

  4. Benjamin Franzke uploaded patch set 2 09/05/19, 12:24

  5. Benjamin Franzke uploaded patch set 3 09/05/19, 12:27

  6. Benjamin Franzke wrote 09/05/19, 12:28

    Topic set to di
  7. TYPO3com voted on patch set 2 V -1 09/05/19, 12:37 Completed build in 12m 34s on Thu, 5 Sep, 12:37 PM Test Summary: 17 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36095

  8. TYPO3com voted on patch set 3 V +1 09/05/19, 12:43 Completed build in 12m 24s on Thu, 5 Sep, 12:43 PM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36097

  9. Benjamin Franzke uploaded patch set 4 09/05/19, 12:55

  10. TYPO3com voted on patch set 4 V -1 09/05/19, 13:08 Completed build in 12m 14s on Thu, 5 Sep, 01:08 PM Test Summary: 4 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36101

  11. Benjamin Franzke uploaded patch set 5 09/05/19, 14:29

  12. TYPO3com voted on patch set 5 V +1 09/05/19, 14:40 Completed build in 10m 48s on Thu, 5 Sep, 02:40 PM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36103

  13. Benjamin Franzke uploaded patch set 6 09/06/19, 11:58

  14. TYPO3com voted on patch set 6 V -1 09/06/19, 11:58 Completed build in 16s on Fri, 6 Sep, 11:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36136

  15. Benjamin Franzke uploaded patch set 7 09/06/19, 12:01

  16. TYPO3com voted on patch set 7 V -1 09/06/19, 12:12 Completed build in 10m 47s on Fri, 6 Sep, 12:12 PM Test Summary: 1 of 47728 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36137

  17. TYPO3com commented on patch set 7 09/06/19, 12:31 Completed build in 11m 00s on Fri, 6 Sep, 12:31 PM Test Summary: 47081 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36140

  18. TYPO3com commented on patch set 7 09/06/19, 18:28 Completed build in 09m 10s on Fri, 6 Sep, 06:28 PM Test Summary: 47131 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36153

  19. TYPO3com voted on patch set 7 V +1 09/06/19, 18:40 Completed build in 09m 50s on Fri, 6 Sep, 06:40 PM Test Summary: 47378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36154

  20. Benjamin Franzke uploaded patch set 8 09/08/19, 13:58

  21. TYPO3com voted on patch set 8 V +1 09/08/19, 14:08 Completed build in 09m 33s on Sun, 8 Sep, 02:08 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36188

  22. Benjamin Franzke uploaded patch set 9 09/08/19, 18:50

  23. TYPO3com voted on patch set 9 V -1 09/08/19, 19:01 Completed build in 10m 20s on Sun, 8 Sep, 07:01 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36192

  24. Benjamin Franzke uploaded patch set 10 09/08/19, 19:04

  25. TYPO3com voted on patch set 10 V -1 09/08/19, 19:14 Completed build in 09m 37s on Sun, 8 Sep, 07:14 PM Test Summary: 12 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36193

  26. Benjamin Franzke uploaded patch set 11 09/08/19, 20:46

  27. TYPO3com voted on patch set 11 V +1 09/08/19, 20:55 Completed build in 09m 02s on Sun, 8 Sep, 08:55 PM Test Summary: 47388 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36196

  1. Benjamin Franzke uploaded patch set 12 09/11/19, 04:30

  2. TYPO3com voted on patch set 12 V +1 09/11/19, 04:43 Completed build in 09m 56s on Wed, 11 Sep, 04:43 AM Test Summary: 47468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36271

  3. Benjamin Franzke uploaded patch set 13 09/11/19, 06:17

  4. TYPO3com voted on patch set 13 V -1 09/11/19, 06:38 Completed build in 12m 44s on Wed, 11 Sep, 06:38 AM Test Summary: 1 of 47827 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36278

  5. TYPO3com voted on patch set 13 V +1 09/11/19, 06:45 Completed build in 32m 49s on Wed, 11 Sep, 06:45 AM Test Summary: 47468 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36278

  6. Benjamin Franzke uploaded patch set 14 12/06/19, 08:00

    Rebase
  7. TYPO3com voted on patch set 14 V +1 12/06/19, 08:12 Completed build in 10m 34s on Fri, 6 Dec, 08:12 AM Test Summary: 68778 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39126

  8. Alexander Schnitzler commented on patch set 14 12/06/19, 09:25

    I don't understand how this is supposed to work exactly. After I cherry-pick this change and update the container I only have 3 commands left. Those three that are configured for the FailsafeContainer, all others that are configured via Services.yaml don't show when I run bin/typo3. I am puzzled.

    CommandRegistry.php:202

    I don't understand this sentence.

    CommandRegistry.php:221

    compatbility is missing an "i"

    CommandRegistry.php:222

    dropped -> triggered (maybe)
  9. Benni Mack uploaded patch set 15 12/16/19, 15:06

  10. Benni Mack uploaded patch set 16 12/16/19, 15:07

  11. TYPO3com voted on patch set 15 V +1 12/16/19, 15:16 Completed build in 09m 41s on Mon, 16 Dec, 03:16 PM Test Summary: 68789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39460

  12. TYPO3com voted on patch set 16 V +1 12/16/19, 15:19 Completed build in 09m 09s on Mon, 16 Dec, 03:19 PM Test Summary: 68789 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-39461

  13. Benni Mack uploaded patch set 17 01/29/20, 10:18

  14. TYPO3com voted on patch set 17 V -1 01/29/20, 10:30 Completed build in 12m 01s on Wed, 29 Jan, 10:30 AM Test Summary: 60786 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40311

  15. TYPO3com voted on patch set 17 V +1 01/30/20, 09:07 Completed build in 23h 01m 05s on Thu, 30 Jan, 09:07 AM Test Summary: 70843 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40311

  16. Benjamin Franzke uploaded patch set 18 01/30/20, 21:20

  17. TYPO3com voted on patch set 18 V +1 01/30/20, 21:35 Completed build in 14m 11s on Thu, 30 Jan, 09:35 PM Test Summary: 70855 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-40375

  18. Benni Mack uploaded patch set 19 02/14/20, 13:43

  19. TYPO3com voted on patch set 19 V +1 02/14/20, 13:56 Completed build in 13m 11s on Fri, 14 Feb, 01:56 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-76

  20. Benjamin Franzke updated the commit message in patch set 20 02/14/20, 13:58

  21. Benjamin Franzke commented on patch set 20 02/14/20, 13:59

    CommandRegistry.php:202 Reply

    Done

    CommandRegistry.php:221 Reply

    Ack

    CommandRegistry.php:222 Reply

    Ack.
  22. TYPO3com voted on patch set 20 V +1 02/14/20, 14:11 Completed build in 13m 20s on Fri, 14 Feb, 02:11 PM Test Summary: 71259 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-77

  23. Achim Fritz voted on patch set 20 V +1 CR +1 02/14/20, 18:36

  24. Benni Mack commented on patch set 20 V +2 CR +2 02/14/20, 19:07

    Alex. The latest patch works as expected for me. I will merge it now, but if you experience any issues after this patch let me know.
  25. Benni Mack merged patch set 21 02/14/20, 19:07