Review main Merged

61633[BUGFIX] Fix broken nightlies because of unknown function

Frank Nägler CR +2 V +2 Easy +4 −4 updated 09/06/19, 07:29

Commit message

The minimum version of phpspec/prophecy is 1.7.6 and does not
contain the method `shouldBeCalledOnce()`.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 2

Files 1

Review log 57

  1. Frank Nägler uploaded patch set 1 09/06/19, 07:10

  2. Andreas Kienast updated the commit message in patch set 2 09/06/19, 07:13

  3. Andreas Kienast voted on patch set 2 V +1 CR +1 09/06/19, 07:14

  4. TYPO3com voted on patch set 1 V -1 09/06/19, 07:23 Completed build in 12m 35s on Fri, 6 Sep, 07:23 AM Test Summary: 1 of 47720 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36115

  5. TYPO3com voted on patch set 2 V +1 09/06/19, 07:25 Completed build in 10m 12s on Fri, 6 Sep, 07:25 AM Test Summary: 47361 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36116

  6. Anja Leichsenring voted on patch set 2 V +2 CR +2 09/06/19, 07:29

  7. Anja Leichsenring merged patch set 3 09/06/19, 07:29