Review main Merged

61637[TASK] Upgrade to TypeScript 3.6

Andreas Kienast CR +2 V +2 Easy +17 −14 updated 09/07/19, 19:33

Commit message

After shedding tears, blood and sacrificing brain cells and CPU time, we
finally managed to upgrade the code base to a recent TypeScript version.

With this patch, our code is compiled with TypeScript 3.6, which has
been added by the following command:

  yarn add --dev typescript@~3.6.2

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 11

Review log 1827

Show 2 earlier messages
  1. Andreas Kienast uploaded patch set 1 09/06/19, 19:33

  2. Anja Leichsenring commented on patch set 1 09/06/19, 19:44

    SelectTreeElement.ts:31

    this can go?
  1. TYPO3com voted on patch set 1 V -1 09/06/19, 19:44 Completed build in 10m 31s on Fri, 6 Sep, 07:44 PM Test Summary: 17 of 47737 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36155

  2. Andreas Kienast commented on patch set 1 09/06/19, 20:04

    SelectTreeElement.ts:31 Reply Unresolved

    This is temporary to check whether this can be removed.
  3. Andreas Kienast uploaded patch set 2 09/07/19, 07:23

  4. TYPO3com voted on patch set 2 V +1 09/07/19, 07:34 Completed build in 10m 09s on Sat, 7 Sep, 07:34 AM Test Summary: 47378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36156

  5. Andreas Kienast uploaded patch set 3 09/07/19, 07:34

  6. TYPO3com voted on patch set 3 V +1 09/07/19, 07:44 Completed build in 10m 16s on Sat, 7 Sep, 07:44 AM Test Summary: 47378 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36157

  7. Benjamin Franzke commented on patch set 3 09/07/19, 13:15

    Hey, great you reached that milestone. From what I see most of the changes could already done with typescript 2.4.0 – only `catch` without arguments would require at least typescript 2.5.0. I'd prefer to have two patches here. The first patch (preflight) would be the preparations/cleanups (which are still 2.4.0 compatible) and the second one the actual upgrade to 3.5/3.6 – that way the git-diff of the build-output in the second patch would be very minimal and shows that the upgrade doesn't change/break code. Note: The only changes to the build output would then be the typescript-injected async/await polyfill in DeferredAction/ImmediateAction.js, which has been changed in TypeScript 3.6.2. I've created a test branch which splits this patch into three patches that shows that an update from 2.4.0 to 3.5.0 produces zero changes to the build output, when the cleanups have been applied in a preflight patch: https://github.com/TYPO3/TYPO3.CMS/compare/master...bnf:typescript-3-6-upgrade-splitted The upgrade from 3.5.0 to 3.6.2 then brings a build-output change for DeferredAction/ImmediateAction.js. That means we know what we have to test for, when verifying this patch(es). I know, it's a bit more work, but I think it is worth the work and I'd be willing to review the split patches. What do you think? If you and other reviewers disagree, then I'm fine and wont object a merge – then the splitted branch may at least of help to verify/test the changes in this patch.

    Severity.ts:84 Unresolved

    Trailing newline.

    tsconfig.json:9

    Is there a specific reason why we do not list es2017 here? I mean, es2019 does include es2018, and so on – I think would should either list all (by convention) or only the most recent one.
  8. Andreas Kienast commented on patch set 3 09/07/19, 15:00

    Hey Benjamin, thank you for your detailed reply. I think splitting the patch makes sense, will push another patch.

    tsconfig.json:9 Reply Unresolved

    I just forgot that. Will fix update this definition, thanks.
  9. Andreas Kienast uploaded patch set 4 09/07/19, 15:10

  10. TYPO3com voted on patch set 4 V -1 09/07/19, 15:11 Completed build in 09s on Sat, 7 Sep, 03:11 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36159

  11. Andreas Kienast rebased onto patch set 5 09/07/19, 15:13

  12. TYPO3com voted on patch set 5 V -1 09/07/19, 15:14 Completed build in 08s on Sat, 7 Sep, 03:14 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36162

  13. Andreas Kienast uploaded patch set 6 09/07/19, 16:44

  14. Andreas Kienast commented on patch set 6 CR -2 09/07/19, 16:47

  15. TYPO3com voted on patch set 6 V -1 09/07/19, 16:58 Completed build in 13m 36s on Sat, 7 Sep, 04:58 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36167

  16. Andreas Kienast rebased onto patch set 7 09/07/19, 18:58

  17. Benjamin Franzke uploaded patch set 8 09/07/19, 19:03

  18. Benjamin Franzke voted on patch set 8 V +1 CR +1 09/07/19, 19:05

  19. Andreas Kienast voted on patch set 8 CR 0 09/07/19, 19:09

  20. TYPO3com voted on patch set 7 V +1 09/07/19, 19:13 Completed build in 14m 19s on Sat, 7 Sep, 07:13 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36169

  21. TYPO3com commented on patch set 7 09/07/19, 19:18 Completed build in 13m 19s on Sat, 7 Sep, 07:18 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36170

  22. TYPO3com commented on patch set 8 09/07/19, 19:20 Completed build in 15m 12s on Sat, 7 Sep, 07:20 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36171

  23. Anja Leichsenring voted on patch set 8 V +1 CR +1 09/07/19, 19:23

  24. Benjamin Franzke voted on patch set 8 V +2 CR +2 09/07/19, 19:33

  25. Benjamin Franzke merged patch set 9 09/07/19, 19:33