Review main Merged

61638[TASK] Fix TypeScript sources in preparation to upgrade

Andreas Kienast CR +2 V +2 Normal +131 −61 updated 09/07/19, 18:56

Commit message

To ease the upgrade to TypeScript 3.6, this patch adjusts the source
code in a TS 2.4 compatible way. This way, the upgrade patch stays as
small as possible.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 30

Show 10 more files

Review log 1220

  1. Andreas Kienast uploaded patch set 1 09/07/19, 15:10

  2. Andreas Kienast uploaded patch set 2 09/07/19, 15:13

  3. Andreas Kienast uploaded patch set 3 09/07/19, 15:20

  4. Benjamin Franzke uploaded patch set 4 09/07/19, 15:22

  5. TYPO3com voted on patch set 1 V +1 09/07/19, 15:22 Completed build in 11m 46s on Sat, 7 Sep, 03:22 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36160

  6. TYPO3com voted on patch set 2 V +1 09/07/19, 15:23 Completed build in 09m 32s on Sat, 7 Sep, 03:23 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36161

  7. TYPO3com voted on patch set 3 V +1 09/07/19, 15:31 Completed build in 10m 43s on Sat, 7 Sep, 03:31 PM Test Summary: 47380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36163

  8. TYPO3com voted on patch set 4 V -1 09/07/19, 15:33 Completed build in 10m 08s on Sat, 7 Sep, 03:33 PM Test Summary: 1 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36164

  9. TYPO3com voted on patch set 4 V +1 09/07/19, 15:34 Completed build in 21m 10s on Sat, 7 Sep, 03:34 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36164

  10. Andreas Kienast uploaded patch set 5 09/07/19, 15:41

  11. TYPO3com voted on patch set 5 V -1 09/07/19, 15:51 Completed build in 10m 08s on Sat, 7 Sep, 03:51 PM Test Summary: 1 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36165

  12. TYPO3com voted on patch set 5 V +1 09/07/19, 15:52 Completed build in 21m 09s on Sat, 7 Sep, 03:52 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36165

  13. Benjamin Franzke commented on patch set 5 CR -1 09/07/19, 16:28

    Thanks for doing the split, only some minor things left.

    Modal.ts:367

    I think `as SeverityEnum` is unneeded. severity always gets a type of SeverityEnum assigned, see above: const severity = typeof SeverityEnum[$element.data('severity')] !== 'undefined' ? SeverityEnum[$element.data('severity')] : SeverityEnum.info; Also, I don't see errors/warning when testing with TypeScript 3 without this change.

    Wizard.ts:159

    Better "force" or "forceSelection" instead of "forced"?

    Backend.ts:1018

    This drops the <p> tag, on purpose?
  14. Andreas Kienast commented on patch set 5 09/07/19, 16:39

    Modal.ts:367 Reply Unresolved

    That's strange, for me TS failed because of this. I will check this again.

    Wizard.ts:159 Reply

    Ack

    Backend.ts:1018 Reply Unresolved

    That was intended, but I think I'll add it again for the sake of consistency.
  15. Andreas Kienast uploaded patch set 6 09/07/19, 16:44

  16. Benjamin Franzke voted on patch set 6 V +1 CR +1 09/07/19, 16:53

  17. TYPO3com voted on patch set 6 V +1 09/07/19, 16:55 Completed build in 10m 39s on Sat, 7 Sep, 04:55 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36166

  18. Anja Leichsenring voted on patch set 6 V +1 CR +1 09/07/19, 18:06

  19. Benjamin Franzke voted on patch set 6 V +2 CR +2 09/07/19, 18:56

  20. Benjamin Franzke merged patch set 7 09/07/19, 18:56