61638[TASK] Fix TypeScript sources in preparation to upgrade
Commit message
Review
-
Code review CR +2 Done
- Benjamin Franzke +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Benjamin Franzke +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 30
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/FormEngine/Element/SlugElement.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/ContentContainer.ts+7 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationComponentInterface.ts+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/NavigationContainer.ts+2 −5
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/PageTree.ts+9 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/Toolbar.tsnew+24 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport/Topbar.ts+6 −7
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ContextMenuActions.ts+2 −2
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/DragUploader.ts+1 −0
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ImageManipulation.ts+7 −4
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/LoginRefresh.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/ModuleMenu.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Notification.ts+5 −3
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Severity.ts+1 −1
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Viewport.ts+9 −8
- Build/Sources/TypeScript/backend/Resources/Public/TypeScript/Wizard.ts2+5 −1
- Build/Sources/TypeScript/workspaces/Resources/Public/TypeScript/Backend.ts2+15 −8
- Build/types/TYPO3/index.d.ts+6 −3
- typo3/sysext/backend/Resources/Public/JavaScript/PageTree/PageTree.js+5 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/ContentContainer.js+1 −1
Show 10 more files
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/NavigationContainer.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/PageTree.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/Toolbar.jsnew+13 −0
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport/Topbar.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ContextMenuActions.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/ModuleMenu.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Notification.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Viewport.js+1 −1
- typo3/sysext/backend/Resources/Public/JavaScript/Wizard.js+1 −1
- typo3/sysext/workspaces/Resources/Public/JavaScript/Backend.js+1 −1
Review log 1220
-
Andreas Kienast uploaded patch set 1 09/07/19, 15:10
-
Andreas Kienast uploaded patch set 2 09/07/19, 15:13
-
Andreas Kienast uploaded patch set 3 09/07/19, 15:20
-
Benjamin Franzke uploaded patch set 4 09/07/19, 15:22
-
TYPO3com voted on patch set 1 V +1 09/07/19, 15:22 Completed build in 11m 46s on Sat, 7 Sep, 03:22 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36160
-
TYPO3com voted on patch set 2 V +1 09/07/19, 15:23 Completed build in 09m 32s on Sat, 7 Sep, 03:23 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36161
-
TYPO3com voted on patch set 3 V +1 09/07/19, 15:31 Completed build in 10m 43s on Sat, 7 Sep, 03:31 PM Test Summary: 47380 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36163
-
TYPO3com voted on patch set 4 V -1 09/07/19, 15:33 Completed build in 10m 08s on Sat, 7 Sep, 03:33 PM Test Summary: 1 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36164
-
TYPO3com voted on patch set 4 V +1 09/07/19, 15:34 Completed build in 21m 10s on Sat, 7 Sep, 03:34 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36164
-
Andreas Kienast uploaded patch set 5 09/07/19, 15:41
-
TYPO3com voted on patch set 5 V -1 09/07/19, 15:51 Completed build in 10m 08s on Sat, 7 Sep, 03:51 PM Test Summary: 1 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36165
-
TYPO3com voted on patch set 5 V +1 09/07/19, 15:52 Completed build in 21m 09s on Sat, 7 Sep, 03:52 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36165
-
Benjamin Franzke commented on patch set 5 CR -1 09/07/19, 16:28
Thanks for doing the split, only some minor things left.Modal.ts:367I think `as SeverityEnum` is unneeded. severity always gets a type of SeverityEnum assigned, see above: const severity = typeof SeverityEnum[$element.data('severity')] !== 'undefined' ? SeverityEnum[$element.data('severity')] : SeverityEnum.info; Also, I don't see errors/warning when testing with TypeScript 3 without this change.Wizard.ts:159Better "force" or "forceSelection" instead of "forced"?Backend.ts:1018This drops the <p> tag, on purpose? -
Andreas Kienast commented on patch set 5 09/07/19, 16:39
Modal.ts:367Reply UnresolvedThat's strange, for me TS failed because of this. I will check this again.Wizard.ts:159ReplyAckBackend.ts:1018Reply UnresolvedThat was intended, but I think I'll add it again for the sake of consistency. -
Andreas Kienast uploaded patch set 6 09/07/19, 16:44
-
Benjamin Franzke voted on patch set 6 V +1 CR +1 09/07/19, 16:53
-
TYPO3com voted on patch set 6 V +1 09/07/19, 16:55 Completed build in 10m 39s on Sat, 7 Sep, 04:55 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36166
-
Anja Leichsenring voted on patch set 6 V +1 CR +1 09/07/19, 18:06
-
Benjamin Franzke voted on patch set 6 V +2 CR +2 09/07/19, 18:56
-
Benjamin Franzke merged patch set 7 09/07/19, 18:56