Review main Merged

61639[TASK] Use Workspace API for checking TCA versioning support

Benni Mack CR +2 V +2 Normal +62 −50 updated 09/08/19, 12:59

Commit message

The API method BackendUtility::isTableWorkspaceEnabled($table)
should be used when dealing with a backend context to determine
if a table has versioning support enabled.

This functionality wasn't used consistently throughout TYPO3
Backend / CLI code and should be used in order to determine.

For PageRepository a separate protected method is introduced
to avoid a dependency on BackendUtility.

This patch is a precursor for streamlining the workspaces API further.

Review

  • Code review CR +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Susi Moog +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 17

Review log 67

  1. Benni Mack uploaded patch set 1 09/08/19, 09:51

  2. TYPO3com voted on patch set 1 V +1 09/08/19, 10:02 Completed build in 10m 28s on Sun, 8 Sep, 10:02 AM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36173

  3. Andreas Kienast commented on patch set 1 V +1 09/08/19, 11:40

    Extbase's DataMapper and our WorksapceRestriction classes still check for `versioningWS`. Should be update these occurrences as well?
  4. Andreas Kienast voted on patch set 1 CR +1 09/08/19, 11:54

  5. Benni Mack commented on patch set 1 09/08/19, 12:49

    > Patch Set 1: Verified+1 > > Extbase's DataMapper and our WorksapceRestriction classes still check for `versioningWS`. Should be update these occurrences as well? this will be changed in one of the following patches
  6. Susi Moog voted on patch set 1 V +2 CR +2 09/08/19, 12:59

  7. Susi Moog merged patch set 2 09/08/19, 12:59