61641[BUGFIX] Do not check for pid=-1 when evaluating workspace records
Commit message
Review
-
Code review CR +2 Done
- Susi Moog +2
- Oliver Hader +1
-
Verified V +2 Done
- Susi Moog +2
- Oliver Hader +1
- TYPO3com +1 CI
Issues 1
Files 27
- typo3/sysext/backend/Classes/Controller/EditDocumentController.php+3 −3
- typo3/sysext/backend/Classes/Form/FormDataProvider/AbstractItemProvider.php4+1 −9
- typo3/sysext/backend/Classes/Form/FormDataProvider/EvaluateDisplayConditions.php2+5 −4
- typo3/sysext/backend/Classes/Tree/Repository/PageTreeRepository.php+1 −1
- typo3/sysext/backend/Classes/Utility/BackendUtility.php2+3 −12
- typo3/sysext/backend/Tests/Unit/Form/FormDataProvider/EvaluateDisplayConditionsTest.php+2 −2
- typo3/sysext/core/Classes/Authentication/BackendUserAuthentication.php2+5 −6
- typo3/sysext/core/Classes/Database/Query/Restriction/BackendWorkspaceRestriction.php+3 −3
- typo3/sysext/core/Classes/Database/Query/Restriction/FrontendWorkspaceRestriction.php+1 −1
- typo3/sysext/core/Classes/Database/Query/Restriction/WorkspaceRestriction.php+4 −4
- typo3/sysext/core/Classes/Database/RelationHandler.php2+17 −15
- typo3/sysext/core/Classes/DataHandling/DataHandler.php2+1 −1
- typo3/sysext/core/Classes/DataHandling/PlainDataResolver.php2+16 −3
- typo3/sysext/core/Classes/Domain/Repository/PageRepository.php+0 −3
- typo3/sysext/core/Documentation/Changelog/master/Important-89122-UnifiedEvaluationOfVersionedRecordsInWorkspaces.rstnew+38 −0
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/BackendWorkspaceRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendRestrictionContainerTest.php+9 −9
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/FrontendWorkspaceRestrictionTest.php+2 −2
- typo3/sysext/core/Tests/Unit/Database/Query/Restriction/WorkspaceRestrictionTest.php+2 −2
- typo3/sysext/install/Classes/Updates/PopulatePageSlugs.php+2 −1
Show 7 more files
- typo3/sysext/lowlevel/Classes/Command/MissingRelationsCommand.php2+1 −1
- typo3/sysext/lowlevel/Classes/Integrity/DatabaseIntegrityCheck.php+0 −2
- typo3/sysext/tstemplate/Classes/Controller/TypoScriptTemplateModuleController.php+3 −0
- typo3/sysext/workspaces/Classes/Command/WorkspaceVersionRecordsCommand.php+1 −1
- typo3/sysext/workspaces/Classes/Dependency/ElementEntityProcessor.php+4 −4
- typo3/sysext/workspaces/Classes/Hook/DataHandlerHook.php3+13 −17
- typo3/sysext/workspaces/Classes/Service/WorkspaceService.php+7 −7
Review log 2233
Show 48 earlier messages
-
Benni Mack uploaded patch set 1 09/08/19, 13:35
-
TYPO3com voted on patch set 1 V -1 09/08/19, 13:44 Completed build in 08m 31s on Sun, 8 Sep, 01:44 PM Test Summary: 93 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36187
-
Benni Mack uploaded patch set 2 09/09/19, 14:53
-
TYPO3com voted on patch set 2 V -1 09/09/19, 14:54 Completed build in 22s on Mon, 9 Sep, 02:54 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36221
-
TYPO3com commented on patch set 2 09/09/19, 15:34 Completed build in 40m 24s on Mon, 9 Sep, 03:33 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36221
-
Benni Mack uploaded patch set 3 09/09/19, 15:35
-
TYPO3com voted on patch set 3 V +1 09/09/19, 15:46 Completed build in 10m 45s on Mon, 9 Sep, 03:46 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36225
-
Benni Mack uploaded patch set 4 09/10/19, 05:39
-
TYPO3com voted on patch set 4 V +1 09/10/19, 05:59 Completed build in 17m 55s on Tue, 10 Sep, 05:59 AM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36231
-
Susi Moog commented on patch set 4 09/10/19, 06:24
canAbstractItemProvider.php:1378sure about $result instead of $row?DataHandler.php:6463will generate a notice I guess if the field is not set. -
Benni Mack uploaded patch set 5 09/10/19, 09:14
-
Benni Mack commented on patch set 5 09/10/19, 09:20
Reply
DoneAbstractItemProvider.php:1378ReplyDoneDataHandler.php:6463ReplyDone -
TYPO3com voted on patch set 5 V +1 09/10/19, 09:25 Completed build in 10m 20s on Tue, 10 Sep, 09:25 AM Test Summary: 47434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36242
-
Oliver Hader wrote 09/10/19, 12:50
Removed reviewer Oliver Hader. -
Oliver Hader wrote 09/10/19, 12:50
Removed reviewer Oliver Hader. -
Achim Fritz commented on patch set 5 09/10/19, 13:28
BackendUtility.php:3722do not call the variable "$pidOperator" -
Oliver Hader commented on patch set 5 V -1 CR -1 09/10/19, 14:13
A couple of queries (I did not check all, yet) look wrong (before this patch already)... I'll go through all queries later... this will take some time...Clipboard.php:483That was wrong before already... it's not relevant whether the parent language record is in a workspace or not. The current context is relevant - e.g. the current state would not show new localizations of a record that is live (since its t3ver_wsid is `0`).PageLayoutController.php:1240That's what BackendWorkspaceRestriction is doing... besides that, the query does not seem to be correct. If in a workspace, only workspace versions (placeholders in this case, but no live versions) would be selected... -
Oliver Hader commented on patch set 5 09/10/19, 17:52
AbstractItemProvider.php:1381Really seems to be superfluous given that AbstractDatabaseRecordProvider::getDatabaseRow() returns all fields (including pid and t3ver_oid)EvaluateDisplayConditions.php:894might be simplified without array_key_exists (PHP7)BackendUserAuthentication.php:911might raise a notice in case table is not workspace awarePlainDataResolver.php:184for these kind of lookups we might pre-filter with array_filter in order to avoid '0' as (invalid) uidRelationHandler.php:1561for these kind of lookups we might pre-filter with array_filter in order to avoid '0' as (invalid) uidMissingRelationsCommand.php:268will raise notice in case table is not workspace awareDataHandlerHook.php:1268only stages of "offline" versions should be modified -> change to t3ver_oid <> 0 condition -
Oliver Hader commented on patch set 5 V 0 09/10/19, 21:56
-
Oliver Hader commented on patch set 5 09/11/19, 09:14
Clipboard.php:483ReplyAckPageLayoutController.php:1240ReplyAckAbstractItemProvider.php:1381ReplyDoneEvaluateDisplayConditions.php:894ReplyAckBackendUtility.php:3722ReplyAckBackendUserAuthentication.php:911ReplyAckPlainDataResolver.php:184ReplyAckRelationHandler.php:1561ReplyAckMissingRelationsCommand.php:268ReplyAckDataHandlerHook.php:186notices since it might not be workspace awareDataHandlerHook.php:1268Reply Unresolvedprobably it does not matter, so keep it like this -
Oliver Hader uploaded patch set 6 09/11/19, 10:36
-
Oliver Hader voted on patch set 6 CR +1 09/11/19, 10:37
-
Susi Moog voted on patch set 6 CR +1 09/11/19, 10:42
-
TYPO3com voted on patch set 6 V -1 09/11/19, 10:49 Completed build in 10m 27s on Wed, 11 Sep, 10:49 AM Test Summary: 3 of 47853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36291
-
Oliver Hader voted on patch set 6 V +1 09/11/19, 10:57
-
TYPO3com commented on patch set 6 09/11/19, 10:59 Completed build in 31m 07s on Wed, 11 Sep, 10:59 AM Test Summary: 3 of 47853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36291
-
TYPO3com commented on patch set 6 09/11/19, 11:13 Completed build in 1h 05m 25s on Wed, 11 Sep, 11:13 AM Test Summary: 3 of 47853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36291
-
TYPO3com commented on patch set 6 09/11/19, 11:21 Completed build in 1h 48m 18s on Wed, 11 Sep, 11:21 AM Test Summary: 3 of 47853 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36291
-
Oliver Hader rebased onto patch set 7 09/11/19, 12:05
-
Oliver Hader voted on patch set 7 V +1 CR +1 09/11/19, 12:06
-
TYPO3com voted on patch set 7 V +1 09/11/19, 12:42 Completed build in 32m 37s on Wed, 11 Sep, 12:42 PM Test Summary: 47514 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36305
-
Susi Moog voted on patch set 7 V +2 CR +2 09/11/19, 12:43
-
Susi Moog merged patch set 8 09/11/19, 12:44