Review main Merged

61642[TASK] Update Fluid engine to 2.6.4

Claus Due CR +2 V +2 Easy +12 −12 updated 09/23/19, 13:47

Commit message

Addresses the following issues:

* Fixes an annotation that makes phpdocumentor/reflection-docblock
  throw exceptions in TYPO3v10.
* Removes deprecation warning from composer due
  to incorrectly cased package name.
* Fixes issues with binary characters in compiled templates.
* Supports overloaded methods for variable extraction.
* Avoids signature issues with CompileWithRenderStatic.
* Works around PCRE regression issues on affected platforms.

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 6

Review log 1826

Show 1 earlier messages
  1. Claus Due uploaded patch set 1 09/08/19, 14:14

  1. TYPO3com voted on patch set 1 V +1 09/08/19, 14:24 Completed build in 10m 14s on Sun, 8 Sep, 02:24 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36189

  2. Mathias Brodala voted on patch set 1 CR +1 09/09/19, 07:04

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/09/19, 07:07

  4. Susi Moog commented on patch set 1 CR -1 09/11/19, 12:02

    first off: please add the composer command used to update to the commit message second: the lock file will only influence packaged versions - shouldn't we also adjust the composer.json (as that currently states 2.6.1)?
  5. Claus Due commented on patch set 1 09/11/19, 17:09

    > Patch Set 1: Code-Review-1 > > first off: please add the composer command used to update to the commit message Will do, it's been a while since my last commit ;) > second: the lock file will only influence packaged versions - shouldn't we also adjust the composer.json (as that currently states 2.6.1)? True, composer.json should also be updated - meanwhile, the Neos team detected a regression so I will be releasing 2.6.3 shortly, then I will update this merge request to use 2.6.3.
  6. Claus Due uploaded patch set 2 09/16/19, 06:49

  7. Claus Due uploaded patch set 3 09/16/19, 06:58

  8. TYPO3com voted on patch set 3 V -1 09/16/19, 06:58 Completed build in 11s on Mon, 16 Sep, 06:58 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36461

  9. TYPO3com voted on patch set 2 V +1 09/16/19, 07:01 Completed build in 11m 11s on Mon, 16 Sep, 07:01 AM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36460

  10. Andreas Kienast uploaded patch set 4 09/16/19, 07:29

  11. Andreas Kienast voted on patch set 4 V +1 CR +1 09/16/19, 07:36

  12. TYPO3com voted on patch set 4 V -1 09/16/19, 07:42 Completed build in 10m 13s on Mon, 16 Sep, 07:42 AM Test Summary: 47556 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36465

  13. Claus Due uploaded patch set 5 09/17/19, 08:44

  14. TYPO3com voted on patch set 5 V -1 09/17/19, 08:44 Completed build in 17s on Tue, 17 Sep, 08:44 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36488

  15. Andreas Kienast uploaded patch set 6 09/18/19, 11:47

  16. TYPO3com voted on patch set 6 V -1 09/18/19, 11:59 Completed build in 11m 06s on Wed, 18 Sep, 11:59 AM Test Summary: 1 of 47914 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36543

  17. TYPO3com voted on patch set 6 V +1 09/18/19, 12:01 Completed build in 24m 20s on Wed, 18 Sep, 12:01 PM Test Summary: 47555 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36543

  18. Andreas Kienast voted on patch set 6 V +1 CR +1 09/18/19, 12:25

  19. Daniel Goerz voted on patch set 6 CR +1 09/18/19, 17:14

  20. Oliver Klee voted on patch set 6 CR +1 09/18/19, 19:31

  21. Anja Leichsenring uploaded patch set 7 09/23/19, 13:14

  22. TYPO3com voted on patch set 7 V +1 09/23/19, 13:37 Completed build in 15m 23s on Mon, 23 Sep, 01:37 PM Test Summary: 47739 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36680

  23. Andreas Kienast voted on patch set 7 V +1 CR +1 09/23/19, 13:45

  24. Anja Leichsenring voted on patch set 7 V +2 CR +2 09/23/19, 13:47

  25. Anja Leichsenring merged patch set 8 09/23/19, 13:47