Review main Merged

61643[BUGFIX] Remove leftover functionality for workspace reviewers and vtypes

Benni Mack CR +2 V +2 Hard +175 −209 updated 09/09/19, 07:19

Commit message

EXT:workspace code has leftover functionality from "reviewers" and "vtypes".

* "vtypes" defined whether element-, branch or page-type versioning was used until TYPO3 v4.x.
* "reviewers" defined a database field which was migrated to responsible persons for a stage

The database fields are fully removed, as well as database access (for the empty fields) and labels.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Daniel Gorges +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 14

Review log 911

  1. Benni Mack uploaded patch set 1 09/08/19, 14:24

  2. Oliver Hader commented on patch set 1 CR +1 09/08/19, 14:30

    Basically workspace owners are not notified (which is better), however it also is a change in behaviour
  3. Oliver Hader commented on patch set 1 09/08/19, 14:31

    > Patch Set 1: Code-Review+1 > > Basically workspace owners are not notified (which is better), however it also is a change in behaviour ... owners are *NOW* notified ...
  4. TYPO3com voted on patch set 1 V -1 09/08/19, 14:33 Completed build in 09m 16s on Sun, 8 Sep, 02:33 PM Test Summary: 36 of 47741 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36190

  5. Benni Mack uploaded patch set 2 09/08/19, 14:40

  6. TYPO3com voted on patch set 2 V +1 09/08/19, 14:50 Completed build in 09m 38s on Sun, 8 Sep, 02:50 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36191

  7. Georg Ringer voted on patch set 2 V +1 CR +1 09/08/19, 18:18

  8. Daniel Gorges voted on patch set 2 V +1 CR +1 09/09/19, 07:10

  9. Benni Mack voted on patch set 2 V +2 CR +2 09/09/19, 07:18

  10. Benni Mack merged patch set 3 09/09/19, 07:18

  11. Susi Moog voted on patch set 3 V +1 CR +1 09/09/19, 07:19