61644[TASK] Cleanup and de-duplicate Extension Configuration and Constant Editing
Commit message
Review
-
Code review CR +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
-
Verified V +2 Done
- Andreas Kienast +2
- Anja Leichsenring +1
- TYPO3com +1 CI
Issues 1
Files 9
- typo3/sysext/core/Classes/Configuration/ExtensionConfiguration.php+24 −297
- typo3/sysext/core/Classes/TypoScript/Parser/ConstantConfigurationParser.phpnew+325 −0
- typo3/sysext/core/Classes/TypoScript/Parser/TypoScriptParser.php+6 −1
- typo3/sysext/core/Classes/TypoScript/ExtendedTemplateService.php+17 −149
- typo3/sysext/core/Classes/TypoScript/TemplateService.php+1 −23
- typo3/sysext/core/Classes/Utility/ArrayUtility.php+10 −4
- typo3/sysext/core/Tests/Unit/TypoScript/Parser/ConstantConfigurationParserTest.phpnew+116 −0
- typo3/sysext/core/Tests/Unit/Utility/ArrayUtilityTest.php+122 −0
- typo3/sysext/install/Classes/Service/ExtensionConfigurationService.php+15 −290
Review log 1624
-
Susi Moog uploaded patch set 1 09/08/19, 19:51
-
Susi Moog marked it work in progress 09/08/19, 19:51
-
TYPO3com voted on patch set 1 V -1 09/08/19, 19:51 Completed build in 12s on Sun, 8 Sep, 07:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36194
-
Susi Moog uploaded patch set 2 09/08/19, 19:52
-
TYPO3com voted on patch set 2 V -1 09/08/19, 20:02 Completed build in 10m 25s on Sun, 8 Sep, 08:02 PM Test Summary: 47381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36195
-
TYPO3com voted on patch set 2 V +1 09/09/19, 04:55 Completed build in 9h 13m 42s on Mon, 9 Sep, 04:55 AM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36195
-
Susi Moog uploaded patch set 3 09/09/19, 05:45
-
TYPO3com voted on patch set 3 V -1 09/09/19, 05:57 Completed build in 11m 07s on Mon, 9 Sep, 05:57 AM Test Summary: 46890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36202
-
Susi Moog uploaded patch set 4 09/09/19, 06:25
-
TYPO3com voted on patch set 4 V +1 09/09/19, 06:42 Completed build in 10m 47s on Mon, 9 Sep, 06:42 AM Test Summary: 47410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36203
-
Susi Moog updated the commit message in patch set 5 09/09/19, 06:47
-
TYPO3com voted on patch set 5 V +1 09/09/19, 06:57 Completed build in 09m 21s on Mon, 9 Sep, 06:57 AM Test Summary: 47410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36204
-
Susi Moog commented on patch set 5 09/09/19, 07:23
This change is ready for review. -
Andreas Kienast commented on patch set 5 V -1 09/09/19, 07:44
Extension configuration in Install Tool is broken: Too few arguments to function TYPO3\CMS\Install\Service\ExtensionConfigurationService::__construct(), 0 passed in typo3/sysext/install/Classes/Controller/SettingsController.php on line 380 and exactly 1 expected -
Andreas Kienast uploaded patch set 6 09/09/19, 07:45
-
TYPO3com voted on patch set 6 V +1 09/09/19, 07:56 Completed build in 10m 13s on Mon, 9 Sep, 07:56 AM Test Summary: 47410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36206
-
Susi Moog marked it work in progress 09/09/19, 09:00
-
Susi Moog uploaded patch set 7 09/09/19, 11:46
-
TYPO3com voted on patch set 7 V +1 09/09/19, 11:56 Completed build in 09m 51s on Mon, 9 Sep, 11:56 AM Test Summary: 47418 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36214
-
Susi Moog commented on patch set 7 09/09/19, 12:42
This change is ready for review. -
Andreas Kienast voted on patch set 7 V +1 CR +1 09/09/19, 13:04
-
Anja Leichsenring voted on patch set 7 V +1 CR +1 09/10/19, 06:41
-
Andreas Kienast voted on patch set 7 V +2 CR +2 09/10/19, 07:38
-
Andreas Kienast merged patch set 8 09/10/19, 07:38