Review main Merged

61644[TASK] Cleanup and de-duplicate Extension Configuration and Constant Editing

Susi Moog CR +2 V +2 Expert +636 −764 updated 09/10/19, 07:38

Commit message

* Use the same parser for constants no matter the context
* Use a dedicated class for constant configuration parsing
* Remove custom flatten implementation and use ArrayUtility
* Use the TypoScriptParser for value parsing of constants
* Remove Code Duplication

Review

  • Code review CR +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
  • Verified V +2 Done
    • Andreas Kienast +2
    • Anja Leichsenring +1
    • TYPO3com +1 CI

Issues 1

Files 9

Review log 1624

  1. Susi Moog uploaded patch set 1 09/08/19, 19:51

  2. Susi Moog marked it work in progress 09/08/19, 19:51

  3. TYPO3com voted on patch set 1 V -1 09/08/19, 19:51 Completed build in 12s on Sun, 8 Sep, 07:51 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36194

  4. Susi Moog uploaded patch set 2 09/08/19, 19:52

  5. TYPO3com voted on patch set 2 V -1 09/08/19, 20:02 Completed build in 10m 25s on Sun, 8 Sep, 08:02 PM Test Summary: 47381 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36195

  6. TYPO3com voted on patch set 2 V +1 09/09/19, 04:55 Completed build in 9h 13m 42s on Mon, 9 Sep, 04:55 AM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36195

  7. Susi Moog uploaded patch set 3 09/09/19, 05:45

  8. TYPO3com voted on patch set 3 V -1 09/09/19, 05:57 Completed build in 11m 07s on Mon, 9 Sep, 05:57 AM Test Summary: 46890 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36202

  9. Susi Moog uploaded patch set 4 09/09/19, 06:25

  10. TYPO3com voted on patch set 4 V +1 09/09/19, 06:42 Completed build in 10m 47s on Mon, 9 Sep, 06:42 AM Test Summary: 47410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36203

  11. Susi Moog updated the commit message in patch set 5 09/09/19, 06:47

  12. TYPO3com voted on patch set 5 V +1 09/09/19, 06:57 Completed build in 09m 21s on Mon, 9 Sep, 06:57 AM Test Summary: 47410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36204

  13. Susi Moog commented on patch set 5 09/09/19, 07:23

    This change is ready for review.
  14. Andreas Kienast commented on patch set 5 V -1 09/09/19, 07:44

    Extension configuration in Install Tool is broken: Too few arguments to function TYPO3\CMS\Install\Service\ExtensionConfigurationService::__construct(), 0 passed in typo3/sysext/install/Classes/Controller/SettingsController.php on line 380 and exactly 1 expected
  15. Andreas Kienast uploaded patch set 6 09/09/19, 07:45

  16. TYPO3com voted on patch set 6 V +1 09/09/19, 07:56 Completed build in 10m 13s on Mon, 9 Sep, 07:56 AM Test Summary: 47410 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36206

  17. Susi Moog marked it work in progress 09/09/19, 09:00

  18. Susi Moog uploaded patch set 7 09/09/19, 11:46

  19. TYPO3com voted on patch set 7 V +1 09/09/19, 11:56 Completed build in 09m 51s on Mon, 9 Sep, 11:56 AM Test Summary: 47418 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36214

  20. Susi Moog commented on patch set 7 09/09/19, 12:42

    This change is ready for review.
  21. Andreas Kienast voted on patch set 7 V +1 CR +1 09/09/19, 13:04

  22. Anja Leichsenring voted on patch set 7 V +1 CR +1 09/10/19, 06:41

  23. Andreas Kienast voted on patch set 7 V +2 CR +2 09/10/19, 07:38

  24. Andreas Kienast merged patch set 8 09/10/19, 07:38