Review main Merged

61646[BUGFIX] Fix configuration composition for nested structures

Andreas Kienast CR +2 V +2 Normal +129 −5 updated 09/10/19, 06:12

Commit message

When a new site configuration gets written, removed values are
determined first and changed values are determined afterwards to keep
nested structures intact.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Susi Moog +1
  • Verified V +2 Done
    • Benni Mack +2
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 2

Files 4

Review log 912

  1. Andreas Kienast uploaded patch set 1 09/09/19, 08:42

  2. Andreas Kienast uploaded patch set 2 09/09/19, 08:48

  3. Andreas Kienast uploaded patch set 3 09/09/19, 08:49

  4. TYPO3com voted on patch set 1 V +1 09/09/19, 08:53 Completed build in 10m 55s on Mon, 9 Sep, 08:53 AM Test Summary: 47386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36208

  5. TYPO3com voted on patch set 2 V +1 09/09/19, 08:59 Completed build in 11m 35s on Mon, 9 Sep, 08:59 AM Test Summary: 47386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36209

  6. TYPO3com voted on patch set 3 V +1 09/09/19, 09:02 Completed build in 11m 47s on Mon, 9 Sep, 09:01 AM Test Summary: 47386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36210

  7. Benni Mack commented on patch set 3 09/09/19, 09:03

    shouldn't this go into v9 as well?
  8. Andreas Kienast commented on patch set 3 09/09/19, 09:24

    > Patch Set 3: > > shouldn't this go into v9 as well? The v9 backport of the original isn't merged yet. I'd fix the backport.
  9. Susi Moog voted on patch set 3 CR +1 09/09/19, 12:49

  10. Susi Moog voted on patch set 3 V +1 09/10/19, 05:55

  11. Benni Mack voted on patch set 3 V +2 CR +2 09/10/19, 06:12

  12. Benni Mack merged patch set 4 09/10/19, 06:12