61646[BUGFIX] Fix configuration composition for nested structures
Commit message
Review
-
Code review CR +2 Done
- Benni Mack +2
- Susi Moog +1
-
Verified V +2 Done
- Benni Mack +2
- Susi Moog +1
- TYPO3com +1 CI
Issues 2
Files 4
- typo3/sysext/core/Classes/Configuration/SiteConfiguration.php+8 −5
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2.yamlnew+35 −0
- typo3/sysext/core/Tests/Unit/Configuration/Fixtures/SiteConfigs/config2_expected.yamlnew+47 −0
- typo3/sysext/core/Tests/Unit/Configuration/SiteConfigurationTest.php+39 −0
Review log 912
-
Andreas Kienast uploaded patch set 1 09/09/19, 08:42
-
Andreas Kienast uploaded patch set 2 09/09/19, 08:48
-
Andreas Kienast uploaded patch set 3 09/09/19, 08:49
-
TYPO3com voted on patch set 1 V +1 09/09/19, 08:53 Completed build in 10m 55s on Mon, 9 Sep, 08:53 AM Test Summary: 47386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36208
-
TYPO3com voted on patch set 2 V +1 09/09/19, 08:59 Completed build in 11m 35s on Mon, 9 Sep, 08:59 AM Test Summary: 47386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36209
-
TYPO3com voted on patch set 3 V +1 09/09/19, 09:02 Completed build in 11m 47s on Mon, 9 Sep, 09:01 AM Test Summary: 47386 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36210
-
Benni Mack commented on patch set 3 09/09/19, 09:03
shouldn't this go into v9 as well? -
Andreas Kienast commented on patch set 3 09/09/19, 09:24
> Patch Set 3: > > shouldn't this go into v9 as well? The v9 backport of the original isn't merged yet. I'd fix the backport. -
Susi Moog voted on patch set 3 CR +1 09/09/19, 12:49
-
Susi Moog voted on patch set 3 V +1 09/10/19, 05:55
-
Benni Mack voted on patch set 3 V +2 CR +2 09/10/19, 06:12
-
Benni Mack merged patch set 4 09/10/19, 06:12