Review main Merged

61648[TASK] Add default value to unused parameter in addPItoST43()

TYPO3com CR +2 V +2 Easy +1 −1 updated 09/09/19, 13:56

Commit message

The second argument of ExtensionManagementUtility::addPItoST43() has been
made obsolete with TYPO3 v8, but is still required when using the method.
This patch sets the default value of that argument to an empty string to
make the argument truly optional.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Benjamin Franzke +2
    • Oli Bartsch +1
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 58

  1. TYPO3com uploaded patch set 1 09/09/19, 13:29

  2. Andreas Kienast updated the commit message in patch set 2 09/09/19, 13:33

  3. TYPO3com voted on patch set 1 V +1 09/09/19, 13:40 Completed build in 11m 32s on Mon, 9 Sep, 01:40 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36216

  4. TYPO3com voted on patch set 2 V +1 09/09/19, 13:43 Completed build in 09m 27s on Mon, 9 Sep, 01:43 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36217

  5. Andreas Kienast voted on patch set 2 V +1 CR +1 09/09/19, 13:44

  6. Benjamin Franzke voted on patch set 2 V +2 CR +2 09/09/19, 13:48

  7. Benjamin Franzke merged patch set 3 09/09/19, 13:49

  8. Oli Bartsch voted on patch set 3 V +1 CR +1 09/09/19, 13:56