Review main Merged

61649[TASK] Incorporate ES 6 features

Andreas Kienast CR +2 V +2 Normal +44 −44 updated 09/23/19, 11:14

Commit message

Since the build chain can generate ES6, the TypeScript code should
incorporate these changes.

Namely, this patch changes:
- Use native NodeList over arrays generated by Array.from() where
  possible
- Use explicit string search functions instead of indexOf

Review

  • Code review CR +2 Done
    • Anja Leichsenring +2
    • Frank Nägler +1
    • Susi Moog +1
  • Verified V +2 Done
    • Anja Leichsenring +2
    • Frank Nägler +1
    • TYPO3com +1 CI

Issues 1

Files 37

Show 17 more files

Review log 1116

  1. Andreas Kienast uploaded patch set 1 09/09/19, 14:39

  2. Andreas Kienast uploaded patch set 2 09/09/19, 15:17

  3. Andreas Kienast uploaded patch set 3 09/09/19, 15:24

  4. TYPO3com voted on patch set 2 V +1 09/09/19, 15:29 Completed build in 12m 01s on Mon, 9 Sep, 03:29 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36222

  5. TYPO3com voted on patch set 3 V +1 09/09/19, 15:35 Completed build in 10m 39s on Mon, 9 Sep, 03:35 PM Test Summary: 47382 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36223

  6. Susi Moog commented on patch set 3 CR -1 09/11/19, 13:08

    as discussed on slack: - do not remove return types from closure functions. - check adminpanel change for benefits
  7. Andreas Kienast uploaded patch set 4 09/11/19, 13:52

  8. Andreas Kienast uploaded patch set 5 09/11/19, 13:55

  9. Andreas Kienast uploaded patch set 6 09/11/19, 13:57

  10. TYPO3com voted on patch set 4 V -1 09/11/19, 14:02 Completed build in 10m 02s on Wed, 11 Sep, 02:02 PM Test Summary: 37564 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36320

  11. TYPO3com voted on patch set 4 V +1 09/11/19, 14:14 Completed build in 31m 18s on Wed, 11 Sep, 02:14 PM Test Summary: 47515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36320

  12. TYPO3com voted on patch set 6 V +1 09/11/19, 14:16 Completed build in 17m 55s on Wed, 11 Sep, 02:16 PM Test Summary: 47515 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36323

  13. Susi Moog voted on patch set 6 CR +1 09/12/19, 05:41

  14. Frank Nägler voted on patch set 6 V +1 CR +1 09/12/19, 06:48

  15. Anja Leichsenring voted on patch set 6 V +2 CR +2 09/23/19, 11:14

  16. Anja Leichsenring merged patch set 7 09/23/19, 11:14