Review main Merged

61650[BUGFIX] Handle base paths with mixed FQDN and "/"

Benni Mack CR +2 V +2 Normal +202 −0 updated 09/20/19, 07:10

Commit message

If a site has "/" as its entrypoint but the languages
have FQDNs or subdomains or a mixture between subdomain
the base without domain always gets found and the subdomains
are not considered.

Currently this situation is handled in
  SiteMatcher->getRouteCollectionForAllSites()
which does not fit a certain scheme if there is a mixture.

This change corrects this and adds tests to handle any cases:

- just / as base, and then /de and /en as language base
- just / as base, and then subdmoains or full domains+path as language base
- a full URL as base, and then path parts as language base
- a full URL as base and then full URLs + subdomains as language base
- Also check for http and http variants.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Nicole Hummel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Daniel Gorges +1
    • Nicole Hummel +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1219

  1. Benni Mack uploaded patch set 1 09/09/19, 15:27

  2. TYPO3com voted on patch set 1 V -1 09/09/19, 15:30 Completed build in 20s on Mon, 9 Sep, 03:30 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36224

  3. Nicole Hummel uploaded patch set 2 09/10/19, 10:53

  4. TYPO3com voted on patch set 2 V -1 09/10/19, 10:53 Completed build in 12s on Tue, 10 Sep, 10:53 AM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36246

  5. Nicole Hummel uploaded patch set 3 09/10/19, 11:04

  6. Nicole Hummel uploaded patch set 4 09/10/19, 11:10

  7. TYPO3com voted on patch set 3 V -1 09/10/19, 11:12 Completed build in 08m 31s on Tue, 10 Sep, 11:12 AM Test Summary: 4 of 47299 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36247

  8. TYPO3com voted on patch set 4 V +1 09/10/19, 11:21 Completed build in 10m 18s on Tue, 10 Sep, 11:21 AM Test Summary: 47438 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36248

  9. Nicole Hummel uploaded patch set 5 09/10/19, 11:47

  10. TYPO3com voted on patch set 5 V +1 09/10/19, 11:57 Completed build in 09m 54s on Tue, 10 Sep, 11:57 AM Test Summary: 47438 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36249

  11. Oliver Hader wrote 09/10/19, 12:51

    Removed reviewer Oliver Hader.
  12. Benni Mack uploaded patch set 6 09/17/19, 05:07

  13. TYPO3com voted on patch set 6 V -1 09/17/19, 05:20 Completed build in 12m 41s on Tue, 17 Sep, 05:20 AM Test Summary: 1 of 47923 failed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36478

  14. TYPO3com voted on patch set 6 V +1 09/17/19, 05:41 Completed build in 46m 22s on Tue, 17 Sep, 05:41 AM Test Summary: 47562 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36478

  15. Benni Mack voted on patch set 6 V +1 CR +1 09/17/19, 06:08

  16. Nicole Hummel voted on patch set 6 V +1 CR +1 09/19/19, 19:39

  17. Daniel Gorges voted on patch set 6 V +1 CR +1 09/20/19, 07:08

  18. Benni Mack voted on patch set 6 V +2 CR +2 09/20/19, 07:10

  19. Benni Mack merged patch set 7 09/20/19, 07:10