Review 9.5 Merged

61652[BUGFIX] Ensure LogManager has requestId set

Helmut Hummel CR +2 V +2 Easy +6 −2 updated 09/10/19, 09:59

Commit message

Since LogManager is first used when ErrorHandler is instantiated,
we need to provide a properly set up singleton before
setting up error handling.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benni Mack +2
    • Benjamin Franzke +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 610

  1. Helmut Hummel uploaded patch set 1 09/09/19, 21:21

  2. Helmut Hummel commented on patch set 1 09/09/19, 21:23

    @Benjamin: can you have a look here? This is already fixed in master, but needs a fix for 9.5 as well
  3. TYPO3com voted on patch set 1 V -1 09/09/19, 21:34 Completed build in 12m 06s on Mon, 9 Sep, 09:34 PM Test Summary: 50325 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1127

  4. TYPO3com commented on patch set 1 09/09/19, 22:08 Completed build in 11m 34s on Mon, 9 Sep, 10:08 PM Test Summary: 50323 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1128

  5. Benjamin Franzke commented on patch set 1 V +1 CR +1 09/09/19, 22:22

    Ack, looks good. For reference, on master we fixed this implicitly with the initial DI patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/58255
  6. TYPO3com commented on patch set 1 09/09/19, 22:27 Completed build in 10m 18s on Mon, 9 Sep, 10:27 PM Test Summary: 40485 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1129

  7. TYPO3com voted on patch set 1 V +1 09/09/19, 22:34 Completed build in 10m 42s on Mon, 9 Sep, 10:34 PM Test Summary: 50612 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1130

  8. Benni Mack voted on patch set 1 V +2 CR +2 09/10/19, 05:50

  9. Benni Mack merged patch set 2 09/10/19, 05:50

  10. Helmut Hummel commented on patch set 2 09/10/19, 09:59

    Thanks!