Review main Merged

61655[BUGFIX] Support mark symbols in slug generation

Andreas Kienast CR +2 V +2 Easy +31 −1 updated 09/10/19, 13:34

Commit message

Currently, slug sanitization removes a wide range of characters not
assumed suitable for slugs, for example single accent characters or
control characters. This patch adds support for mark characters used for
example in the devanagari alphabet.

Review

  • Code review CR +2 Done
    • Daniel Goerz +2
    • Jigal van Hemert +1
    • Susi Moog +1
    • Benni Mack +1
  • Verified V +2 Done
    • Daniel Goerz +2
    • Jigal van Hemert +1
    • Susi Moog +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 78

  1. Andreas Kienast uploaded patch set 1 09/10/19, 09:05

  2. Benni Mack voted on patch set 1 CR +1 09/10/19, 09:07

  3. TYPO3com voted on patch set 1 V +1 09/10/19, 09:16 Completed build in 10m 52s on Tue, 10 Sep, 09:16 AM Test Summary: 47458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36241

  4. Jigal van Hemert voted on patch set 1 V +1 CR +1 09/10/19, 09:25

  5. Susi Moog voted on patch set 1 V +1 CR +1 09/10/19, 09:48

  6. Daniel Goerz voted on patch set 1 V +2 CR +2 09/10/19, 13:32

  7. Daniel Goerz merged patch set 2 09/10/19, 13:32

  8. Mathias Brodala commented on patch set 2 09/10/19, 13:34

    SlugHelperTest.php:319 Unresolved

    Aka "Hiragana". ;-)