Review 9.5 Merged

61657[BUGFIX] Do not fall back to routes on invalid “id”

Claus Due CR +2 V +2 Easy +9 −1 updated 11/06/19, 15:53

Commit message

Prevents a logic issue where any failure to load
a record from “pages” based on $_GET[‘id’]
would cause incorrect behavior of falling back
to the site’s configured root page.

Inability to load the page record requested with
“id” in URL must trigger pageNotFoundAction
instead of rendering the site’s root page.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Henning Liebe +1
  • Verified V +2 Done
    • Benni Mack +2
    • Henning Liebe +1
    • TYPO3com +1 CI

Issues 1

Files 1

Review log 68

  1. Claus Due uploaded patch set 1 09/10/19, 12:03

  2. TYPO3com voted on patch set 1 V -1 09/10/19, 12:04 Completed build in 06s on Tue, 10 Sep, 12:04 PM Test Summary: No tests found Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36250

  3. Claus Due wrote 09/10/19, 12:05

    Change destination moved from master to 9.5
  4. Oliver Hader rebased onto patch set 2 09/11/19, 12:30

  5. TYPO3com voted on patch set 2 V +1 09/11/19, 13:08 Completed build in 35m 58s on Wed, 11 Sep, 01:08 PM Test Summary: 50665 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC95-1143

  6. Henning Liebe voted on patch set 2 V +1 CR +1 10/09/19, 11:35

  7. Benni Mack voted on patch set 2 V +2 CR +2 11/06/19, 15:53

  8. Benni Mack merged patch set 3 11/06/19, 15:53