Review main Merged

61659[BUGFIX] Use RuntimeException instead of die()

Benni Mack CR +2 V +2 Easy +6 −4 updated 09/11/19, 06:38

Commit message

There are a few places left where Kasper-Kode stopped
a process with die(). Nowadays, with PHP 7, Errors and
Exceptions are used in order to avoid the full stop
of a process.

Using Exceptions instead of die() allows for
ExceptionHandlers to handle such an error and
return a proper HTTP response if called from the web.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Richard Haeser +1
    • Andreas Kienast +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Andreas Kienast +1
    • TYPO3com +1 CI

Issues 1

Files 2

Review log 1215

  1. Benni Mack uploaded patch set 1 09/10/19, 13:30

  2. TYPO3com voted on patch set 1 V +1 09/10/19, 13:43 Completed build in 12m 34s on Tue, 10 Sep, 01:43 PM Test Summary: 47434 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36256

  3. Andreas Kienast voted on patch set 1 V +1 CR +1 09/10/19, 14:02

  4. Oliver Klee commented on patch set 1 09/10/19, 14:06

    BackendUtility.php:2820 Unresolved

    We then should have the corresponding @throws annotations here.

    GeneralUtility.php:3721 Unresolved

    Here, an @throws annotation is needed as well.
  5. Richard Haeser uploaded patch set 2 09/10/19, 21:20

  6. Richard Haeser voted on patch set 2 V +1 CR +1 09/10/19, 21:22

  7. TYPO3com voted on patch set 2 V +1 09/10/19, 21:29 Completed build in 08m 15s on Tue, 10 Sep, 09:29 PM Test Summary: 47458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36266

  8. Oliver Klee voted on patch set 2 CR +1 09/10/19, 21:32

  9. Georg Ringer commented on patch set 2 CR -1 09/11/19, 02:16

    GeneralUtility.php:3740 Unresolved

    IMO this won'T work having HTML in the exception message. maybe setting 3rd parameter of viewArray to true?
  10. Benni Mack uploaded patch set 3 09/11/19, 05:31

  11. TYPO3com voted on patch set 3 V +1 09/11/19, 05:55 Completed build in 23m 49s on Wed, 11 Sep, 05:55 AM Test Summary: 47458 passed Find logs and detail information at https://bamboo.typo3.com/browse/CORE-GTC-36274

  12. Andreas Kienast voted on patch set 3 V +1 CR +1 09/11/19, 05:56

  13. Richard Haeser voted on patch set 3 CR +1 09/11/19, 05:57

  14. Georg Ringer voted on patch set 3 V +2 CR +2 09/11/19, 06:38

  15. Georg Ringer merged patch set 4 09/11/19, 06:38